From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode Date: Tue, 25 Oct 2016 15:28:02 -0700 Message-ID: <20161025222802.GC5184@intel.com> References: <1477093543-11622-1-git-send-email-manasi.d.navare@intel.com> <1477093543-11622-2-git-send-email-manasi.d.navare@intel.com> <87twc0mxz0.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87twc0mxz0.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMjUsIDIwMTYgYXQgMDM6MDk6MzlQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gU2F0LCAyMiBPY3QgMjAxNiwgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJl QGludGVsLmNvbT4gd3JvdGU6Cj4gPiBUaGlzIGZ1bmN0aW9uIHByb3ZpZGVzIGEgd2F5IGZvciB0 aGUgZHJpdmVyIHRvIHJlZG8gYQo+ID4gbW9kZXNldCBvbiB0aGUgY3VycmVudCBtb2RlIGFuZCBy ZXRyeSB0aGUgbGluayB0cmFpbmluZwo+ID4gYXQgYSBsb3dlciBsaW5rIHJhdGUvbGFuZSBjb3Vu dC9icHAuIFRoaXMgd2lsbCBnZXQgY2FsbGVkCj4gPiBpbmNhc2UgdGhlIGxpbmsgdHJhaW5pbmcg ZmFpbHMgZHVyaW5nIHRoZSBjdXJyZW50IG1vZGVzZXQuCj4gCj4gQmFzZWQgb24gZGlzY3Vzc2lv bnMgb24gI2ludGVsLWdmeCwgSSB3b3VsZCBkb2RnZSBhbGwgdGhlIHByb2JsZW1zIGhlcmUKPiBi eSBoYXZpbmcgdGhlIHVzZXJzcGFjZSBkbyB0aGUgbW9kZXNldC4KPiAKPiBJZiB3ZSBhZGQgYSBj b25uZWN0b3IgcHJvcGVydHkgdG8gaW5kaWNhdGUgdGhlIGxpbmsgc3RhdHVzIChhbmQgdGhpcwo+ IGRvZXMgbm90IGhhdmUgdG8gYmUgRFAgb3IgbGluayB0cmFpbmluZyBzcGVjaWZpYywgcmVhbGx5 KSwgd2UgY2FuIHNldAo+IHRoYXQgdG8gImJhZCIsIGFuZCBmaXJlIG9mZiB0aGUgaG90cGx1ZyB1 ZXZlbnQuIFRoZW4gdXNlcnNwYWNlIGhhcyB0aGUKPiBpbmZvcm1hdGlvbiB0byBmb3JjZSBhIG1v ZGVzZXQgb24gdGhhdCBjb25uZWN0b3IgZXZlbiBpZiB0aGUgbW9kZSBoYXMKPiBub3QgY2hhbmdl ZC4gKENyZWRpdHMgdG8gVmlsbGUgZm9yIHRoZSBpZGVhLikKPiAKPiBJZiB3ZSBmaW5kIGEgc29s dXRpb24gbGF0ZXIgb24gdGhhdCBhbGxvd3MgdXMgdG8gaGFuZGxlIGFsbCBvZiB0aGlzIGluCj4g a2VybmVsLCB3ZSBjYW4gZG8gc28sIGFuZCByZW1vdmUgdGhlIHByb3BlcnR5IG9yIGFsd2F5cyBy ZXBvcnQKPiAiZ29vZCIuIERyaXZlcnMgY2FuIGNob29zZSBkaWZmZXJlbnQgYXBwcm9hY2hlcywg ZGVwZW5kaW5nIG9uIHRoZQo+IGNhcGFiaWxpdGllcyBvZiB0aGUgaGFyZHdhcmUsIGZvciBpbnN0 YW5jZS4KPiAKPiBEZWZlcnJpbmcgdGhpcyB0byB0aGUgdXNlcnNwYWNlIGRvZXMgbm90IHJlZ3Jl c3MgYW55dGhpbmcgbm93LCBiZWNhdXNlCj4gY3VycmVudGx5IHdlIGp1c3QgY29tcGxldGVseSBm YWlsIGFuZCBlbmQgdXAgd2l0aCBhIGJsYWNrIHNjcmVlbi4gVGhlCj4gcHJvcGVydHkgd291bGQg YWxsb3cgYW4gZW5saWdodGVuZWQgdXNlcnNwYWNlIHRvIGZpeCB0aGF0LiBBbmQgdXNlcnNwYWNl Cj4gY2FuJ3QgcmVseSBvbiB0aGUgcHJvcGVydHkgYmVpbmcgdGhlcmUsIGFzIGl0J3MgY3VycmVu dGx5IG5vdCB0aGVyZS4KPiAKPiAKPiBCUiwKPiBKYW5pLgo+IAo+CgpUaGFua3MgZm9yIHlvdXIg ZmVlZGJhY2sgSmFuaS4gSSB3aWxsIHRyeSBpbXBsZW1lbnRpbmcgdGhpcywgYnV0IGlzbid0IHRo aXMgZ29pbmcKdG8gcmVxdWlyZSBjaGFuZ2VzIGluIGFsbCB0aGUgdXNlcnNwYWNlIGRyaXZlcnMg KG1vZGVzZXR0aW5nIGRyaXZlciwgQ2hyb21lT1MpIHRvCm1ha2UgdXNlIG9mIHRoaXMgbmV3IHBy b3BlcnR5IHRvIHRyaWdnZXIgYW5vdGhlciBtb2Rlc2V0PwpIb3cgZWFzeSB3b3VsZCBpdCBiZSB0 byBoYXZlIGFsbCB0aGUgdXNlcnNwYWNlIGRyaXZlcnMgYWRvcHQgdGhpcyBjaGFuZ2U/CgpSZWdh cmRzCk1hbmFzaQogCj4gPgo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gQ2M6IFZpbGxlIFN5 cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTog TWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgNTggKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+ID4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgg ICAgIHwgIDEgKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKQo+ID4KPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPiBpbmRleCBmOTM2Mjc2Li4wYzE2MTRl IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPiBAQCAtMjg5NSw2 ICsyODk1LDY0IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHBtcyhzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19o ZWxwZXJfY29ubmVjdG9yX2RwbXMpOwo+ID4gIAo+ID4gIC8qKgo+ID4gKyAqIGRybV9hdG9taWNf aGVscGVyX2Nvbm5lY3Rvcl9tb2Rlc2V0IC0gRm9yY2UgYSBtb2Rlc2V0IG9uIGEgY29ubmVjdG9y Cj4gPiArICogQGNvbm5lY3RvcjogRFJNIGNvbm5lY3Rvcgo+ID4gKyAqCj4gPiArICogUHJvdmlk ZXMgYSB3YXkgdG8gcmVkbyBhIG1vZGVzZXQgd2l0aCB0aGUgY3VycmVudCBtb2RlIHNvIHRoYXQg aXQgY2FuCj4gPiArICogZHJvcCB0aGUgYnBwLCBsaW5rIHJhdGUvbGFuZSBjb3VudCBhbmQgcmV0 cnkgdGhlIGxpbmsgdHJhaW5pbmcuCj4gPiArICoKPiA+ICsgKiBSZXR1cm5zOgo+ID4gKyAqIFJl dHVybnMgMCBvbiBzdWNjZXNzLCBuZWdhdGl2ZSBlcnJubyBudW1iZXJzIG9uIGZhaWx1cmUuCj4g PiArICovCj4gPiAraW50Cj4gPiArZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX21vZGVzZXQo c3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1f ZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmRldjsKPiA+ICsJc3RydWN0IGRybV9tb2Rlc2V0X2Fj cXVpcmVfY3R4IGN0eDsKPiA+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ID4g KwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubmVjdG9yX3N0YXRlOwo+ID4gKwlzdHJ1 Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPiArCWludCByZXQgPSAwOwo+ID4gKwo+ ID4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gPiArCXN0YXRlID0gZHJt X2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+ID4gKwlpZiAoIXN0YXRlKSB7Cj4gPiArCQlyZXQg PSAtRU5PTUVNOwo+ID4gKwkJZ290byBmYWlsOwo+ID4gKwl9Cj4gPiArCXN0YXRlLT5hY3F1aXJl X2N0eCA9ICZjdHg7Cj4gPiArcmV0cnk6Cj4gPiArCXJldCA9IDA7Cj4gPiArCWNvbm5lY3Rvcl9z dGF0ZSA9IGRybV9hdG9taWNfZ2V0X2Nvbm5lY3Rvcl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yKTsK PiA+ICsJaWYgKElTX0VSUihjb25uZWN0b3Jfc3RhdGUpKSB7Cj4gPiArCQlyZXQgPSBQVFJfRVJS KGNvbm5lY3Rvcl9zdGF0ZSk7Cj4gPiArCQlnb3RvIGZhaWw7Cj4gPiArCX0KPiA+ICsJaWYgKCFj b25uZWN0b3Jfc3RhdGUtPmNydGMpCj4gPiArCQlnb3RvIGZhaWw7Cj4gPiArCj4gPiArCWNydGNf c3RhdGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLAo+ID4gKwkJ CQkJCQljb25uZWN0b3Jfc3RhdGUtPmNydGMpOwo+ID4gKwljcnRjX3N0YXRlLT5jb25uZWN0b3Jz X2NoYW5nZWQgPSB0cnVlOwo+ID4gKwlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4g PiArZmFpbDoKPiA+ICsJaWYgKHJldCA9PSAtRURFQURMSykgewo+ID4gKwkJZHJtX2F0b21pY19z dGF0ZV9jbGVhcihzdGF0ZSk7Cj4gPiArCQlkcm1fbW9kZXNldF9iYWNrb2ZmKCZjdHgpOwo+ID4g KwkJZ290byByZXRyeTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAoc3RhdGUpCj4gPiArCQlkcm1f YXRvbWljX3N0YXRlX3B1dChzdGF0ZSk7Cj4gPiArCj4gPiArCWRybV9tb2Rlc2V0X2Ryb3BfbG9j a3MoJmN0eCk7Cj4gPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiA+ICsKPiA+ ICsJcmV0dXJuIHJldDsKPiA+ICt9Cj4gPiArRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBl cl9jb25uZWN0b3JfbW9kZXNldCk7Cj4gPiArCj4gPiArLyoqCj4gPiAgICogZHJtX2F0b21pY19o ZWxwZXJfYmVzdF9lbmNvZGVyIC0gSGVscGVyIGZvciAmZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVu Y3MKPiA+ICAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtPmJlc3RfZW5jb2Rl ciBjYWxsYmFjawo+ID4gICAqIEBjb25uZWN0b3I6IENvbm5lY3RvciBjb250cm9sIHN0cnVjdHVy ZQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmggYi9pbmNs dWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gPiBpbmRleCA3ZmY5MmIwLi44ZGUyNGRjIDEw MDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaAo+ID4gKysrIGIv aW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaAo+ID4gQEAgLTEyNiw2ICsxMjYsNyBAQCBp bnQgZHJtX2F0b21pY19oZWxwZXJfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ ICAJCQkJdWludDMyX3QgZmxhZ3MpOwo+ID4gIGludCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3JfZHBtcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAkJCQkgICAgIGlu dCBtb2RlKTsKPiA+ICtpbnQgZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX21vZGVzZXQoc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcik7Cj4gPiAgc3RydWN0IGRybV9lbmNvZGVyICoK PiA+ICBkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3Rvcik7Cj4gCj4gLS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRl Y2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=