From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzDAn-0003TR-KH for qemu-devel@nongnu.org; Tue, 25 Oct 2016 21:38:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzDAk-0006Ki-DY for qemu-devel@nongnu.org; Tue, 25 Oct 2016 21:38:33 -0400 Date: Wed, 26 Oct 2016 11:03:47 +1100 From: David Gibson Message-ID: <20161026000347.GK11052@umbus.fritz.box> References: <1476823604-15403-1-git-send-email-thuth@redhat.com> <20161019021650.GC11140@umbus.fritz.box> <317ca528-643a-42be-0a5a-e5c25bb2dec6@redhat.com> <20161024120450.GH11052@umbus.fritz.box> <70f1e5d4-fb16-ff4e-0eba-42004de90a46@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A/JKaSqKPqQLCbw0" Content-Disposition: inline In-Reply-To: <70f1e5d4-fb16-ff4e-0eba-42004de90a46@redhat.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: "qemu-devel@nongnu.org" , "qemu-ppc@nongnu.org" , Bharata B Rao , Artyom Tarasenko --A/JKaSqKPqQLCbw0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2016 at 02:22:08PM +0200, Thomas Huth wrote: > On 24.10.2016 14:04, David Gibson wrote: > > On Mon, Oct 24, 2016 at 12:36:05PM +0200, Thomas Huth wrote: > >> On 24.10.2016 12:22, Bharata B Rao wrote: > >>> > >>> On Wed, Oct 19, 2016 at 7:46 AM, David Gibson > >>> > wr= ote: > >>> > >>> On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > >>> > The OpenBIOS NVRAM set-up is based on the layout defined in the= CHRP > >>> > (Common Hardware Reference Platform) specification. This is the= same > >>> > layout that is also used by the PAPR specification and thus by = the > >>> SLOF > >>> > firmware of the pseries machine. By refactoring the NVRAM code = =66rom > >>> > mac_nvram.c, we can use the same functions for setting up the N= VRAM > >>> > for both, OpenBIOS and SLOF. This way we can support the "-prom= -env" > >>> > parameter of QEMU for SLOF, too, which is very useful to influe= nce > >>> > the firmware boot process. > >>> > > >>> > Thomas Huth (5): > >>> > nvram: Introduce helper functions for CHRP "system" and "free= space" > >>> > partitions > >>> > sparc: Use the new common NVRAM functions for system and free= space > >>> > partition > >>> > spapr_nvram: Pre-initialize the NVRAM to support the -prom-env > >>> > parameter > >>> > nvram: Move the remaining CHRP NVRAM related code to chrp_nvr= am.[ch] > >>> > nvram: Rename openbios_firmware_abi.h into sun_nvram.h > >>> > > >>> > hw/nvram/Makefile.objs | 1 + > >>> > hw/nvram/chrp_nvram.c | 85 > >>> ++++++++++++++++++++++ > >>> > hw/nvram/mac_nvram.c | 49 +++---= ------- > >>> > hw/nvram/spapr_nvram.c | 6 ++ > >>> > hw/sparc/sun4m.c | 35 ++----= --- > >>> > hw/sparc64/sun4u.c | 35 ++----= --- > >>> > include/hw/nvram/chrp_nvram.h | 54 > >>> ++++++++++++++ > >>> > .../nvram/{openbios_firmware_abi.h =3D> sun_nvram.h} | 47 +---= -------- > >>> > tests/postcopy-test.c | 8 +- > >>> > 9 files changed, 179 insertions(+), 141 deletions(-) > >>> > create mode 100644 hw/nvram/chrp_nvram.c > >>> > create mode 100644 include/hw/nvram/chrp_nvram.h > >>> > rename include/hw/nvram/{openbios_firmware_abi.h =3D> sun_nvra= m.h} > >>> (50%) > >>> > >>> Series, > >>> > >>> Reviewed-by: David Gibson >>> > > >>> > >>> I've put it into ppc-for-2.8 tentatively. However I'd like to ge= t an > >>> Acked-by from Mark for the Sparc bits before I send my next pull > >>> request. > >>> > >>> > >>> I observe an early boot failure in SLOF with a commit from this patch= set > >>> on ppc-for-2.8 branch. > >>> > >>> 4e1257ed41bce16baa8a010 - spapr_nvram: Pre-initialize the NVRAM to > >>> support the -prom-env parameter > >>> > >>> SLOF ****************************************************************= ****** > >>> QEMU Starting > >>> Build Date =3D Oct 19 2016 09:58:38 > >>> FW Version =3D git-efd65f49929d7db7 > >>> Press "s" to enter Open Firmware. > >>> > >>> Populating /vdevice methods > >>> Populating /vdevice/vty@71000000 > >>> Populating /vdevice/nvram@71000001 > >>> Populating /vdevice/v-scsi@71000002 > >>> SCSI: Looking for devices > >>> 8200000000000000 CD-ROM : "QEMU QEMU CD-ROM 2.5+" > >>> Populating /pci@800000020000000 > >>> 00 1000 (D) : 1033 0194 serial bus [ usb-xhci= ] > >>> 00 0800 (D) : 1af4 1001 virtio [ block ] > >>> 00 0000 (D) : 1af4 1000 virtio [ net ] > >>> Scanning USB > >>> XHCI: Initializing > >>> Using default console: /vdevice/vty@71000000 > >>> =20 > >>> Welcome to Open Firmware > >>> > >>> Copyright (c) 2004, 2011 IBM Corporation All rights reserved. > >>> This program and the accompanying materials are made available > >>> under the terms of the BSD License available at > >>> http://www.opensource.org/licenses/bsd-license.php > >>> > >>> > >>> Trying to load: from: /pci@800000020000000/scsi@1 ... Successfully= loaded > >>> error: out of memory. > >>> out of memory > >>> Aborted. Press any key to exit. > >> > >> Yuck. Confirmed. Sorry for the inconvenience. Seems like SLOF does not > >> create the properties in the /options device tree node anymore in this= case. > >> > >> David, could you please unqueue the "spapr_nvram: Pre-initialize the > >> NVRAM to support the -prom-env parameter" patch from the ppc-for-2.8 > >> branch until I figure out a fix for this problem? Thanks! > >=20 > > Done. >=20 > FYI, SLOF patch to fix this issue is on the way: > https://patchwork.ozlabs.org/patch/686426/ Ok. So it was a matter of this change exposing a bug in SLOF, rather than being buggy of itself? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --A/JKaSqKPqQLCbw0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYD/LiAAoJEGw4ysog2bOSm+sQAKJ3I9ljF0pLMOSlwSWv9vSg U4fRscqJ5lD8J0qAmulLwEQW16dzyTgiw3a69XSCUpsFcaZGtF+xE2f03yu3RNyr q4S+IxQs3+JJISX4f+I2PDDz+fcCsXa0f/7xwu/oN3Ha71mbMRbtQ1SihAND9Wmd Ot6OJ2IFnJC8keC8XSnoyCew4d2PDruflIgXQtLq3k+gu5z2RnZsyPId2eVFqGy1 YDfnYvUa5p5V3xX0MtOCO4hhNc+lNRLYPd9lV6mXIenlrV2NE54x0R6zrHb70fzQ +GOTTR3N/DBQDFyK5NKtkz0x3y+TPbFVtG0a7g8H7R/bmChR43OX9oEjg+wWjaFp g3MtRuEnf9WYcQVL/DA5lSCyCIAdTSvhKumdAvqsgupI/1S14BT3AILgmgnyVf7R FFfBPiaqvTLa2u04yZKzGo6iWCmQkbK4DxrXadQ7EuaoXlT4W+DhCgOF+DKlo/u9 GFSyH5yaGgXed8TldG0i1M7ZhMzZN+4KHcFzp73gH8mqLM7KqLQd4Yqh7zdaI7hE SFdxYogevl/gwn6EtSo5boh2qhedShb7Sywpx6cK1w4q4+G5wlcbyfPEWEm8zVtm uxZ4guj0MrbfAuT2BxJKmCDcKREoVxKJKtUHelMJ7RTfUugJCafeKZLyfubve4A7 AD/1dil6DUkBJe9W6Ksf =r/b9 -----END PGP SIGNATURE----- --A/JKaSqKPqQLCbw0--