From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbcJZGIR (ORCPT ); Wed, 26 Oct 2016 02:08:17 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34864 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbcJZGIN (ORCPT ); Wed, 26 Oct 2016 02:08:13 -0400 Date: Wed, 26 Oct 2016 11:37:43 +0530 From: Viresh Kumar To: Stephen Boyd Cc: Rafael Wysocki , nm@ti.com, Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , robh@kernel.org, d-gerlach@ti.com, broonie@kernel.org Subject: Re: [PATCH V2 7/8] PM / OPP: Allow platform specific custom opp_set_rate() callbacks Message-ID: <20161026060743.GK9162@vireshk-i7> References: <4786e1f0958441b03e6d91ce21817898574c45ed.1476952750.git.viresh.kumar@linaro.org> <20161025190114.GV26139@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161025190114.GV26139@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-10-16, 12:01, Stephen Boyd wrote: > On 10/20, Viresh Kumar wrote: > > The generic opp_set_rate() handler isn't sufficient for platforms with > > complex DVFS. For example, some TI platforms have multiple regulators > > for a CPU device. The order in which various supplies need to be > > programmed is only known to the platform code and its best to leave it > > to it. > > > > This patch implements APIs to register platform specific opp_set_rate() > > callback. > > > > Signed-off-by: Viresh Kumar > > --- > > Overall it looks ok, but I'd prefer set_opp instead of set_rate. Done. -- viresh