From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbcJZJs7 (ORCPT ); Wed, 26 Oct 2016 05:48:59 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:32778 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754365AbcJZJsx (ORCPT ); Wed, 26 Oct 2016 05:48:53 -0400 Date: Wed, 26 Oct 2016 17:48:44 +0800 From: Eva Rachel Retuya To: Jonathan Cameron Cc: Arnd Bergmann , Greg Kroah-Hartman , Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: cdc/ad7746: fix missing return value Message-ID: <20161026094839.GA2243@Socrates-DK> Mail-Followup-To: Jonathan Cameron , Arnd Bergmann , Greg Kroah-Hartman , Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20161025155646.64112-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 05:27:07PM +0100, Jonathan Cameron wrote: > On 25/10/16 16:56, Arnd Bergmann wrote: > > As found by "gcc -Wmaybe-uninitialized", the latest change to the > > driver lacked an initalization for the return code in one of the > > added cases: > > > > drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’: > > drivers/staging/iio/cdc/ad7746.c:655:2: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > > > This sets it to IIO_VAL_INT, which I think is what we want here. > > > > Fixes: 2296c0623eb7 ("staging: iio: cdc: ad7746: implement IIO_CHAN_INFO_SAMP_FREQ") > > Signed-off-by: Arnd Bergmann > Gah, not a good bit of reviewing from me. Should have caught that one. Thanks Arnd. > It's not your fault. My apologies. v1 of this patch is OK, I just happen to encounter a problem and had to rework the v2 on another branch resulting to this blunder. I will be extra careful next time. Eva > Applied to the togreg branch of iio.git - initially pushed out as testing for the > autobuilders to play with it. Will probably be a little while before I send > another pull to Greg (most likely the weekend) > > Thanks again, > > Jonathan > > --- > > drivers/staging/iio/cdc/ad7746.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > > index f41251ceeacd..a5828f9aa437 100644 > > --- a/drivers/staging/iio/cdc/ad7746.c > > +++ b/drivers/staging/iio/cdc/ad7746.c > > @@ -642,6 +642,7 @@ static int ad7746_read_raw(struct iio_dev *indio_dev, > > case IIO_VOLTAGE: > > *val = ad7746_vt_filter_rate_table[ > > (chip->config >> 6) & 0x3][0]; > > + ret = IIO_VAL_INT; > > break; > > default: > > ret = -EINVAL; > > >