From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:40581 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754672AbcJZQtA (ORCPT ); Wed, 26 Oct 2016 12:49:00 -0400 Received: by mail-wm0-f68.google.com with SMTP id b80so3983406wme.7 for ; Wed, 26 Oct 2016 09:48:55 -0700 (PDT) Date: Wed, 26 Oct 2016 18:48:50 +0200 From: Daniel Vetter To: Benjamin Gaignard Cc: Sean Paul , Laurent Pinchart , Seung-Woo Kim , dri-devel , Kyungmin Park , stable@vger.kernel.org, Lyude , Vincent Abriou , Marek Szyprowski Subject: Re: [PATCH] drm: Don't force all planes to be added to the state due to zpos Message-ID: <20161026164850.gkym6bhejosltijc@phenom.ffwll.local> References: <1476101987-31986-1-git-send-email-ville.syrjala@linux.intel.com> <20161025144304.GS4617@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, Oct 26, 2016 at 04:09:00PM +0200, Benjamin Gaignard wrote: > I have just tested it on my board, no regression :-) > > Acked-by: Benjamin Gaignard > > 2016-10-25 22:53 GMT+02:00 Sean Paul : > > On Tue, Oct 25, 2016 at 10:43 AM, Ville Syrj�l� > > wrote: > >> On Mon, Oct 10, 2016 at 03:19:47PM +0300, ville.syrjala@linux.intel.com wrote: > >>> From: Ville Syrj�l� > >>> > >>> We don't want all planes to be added to the state whenever a > >>> plane with fixed zpos gets enabled/disabled. This is true > >>> especially for eg. cursor planes on i915, as we want cursor > >>> updates to go through w/o throttling. Same holds for drivers > >>> that don't support zpos at all (i915 actually falls into this > >>> category right now since we've not yet added zpos support). > >>> > >>> Allow drivers more freedom by letting them deal with zpos > >>> themselves instead of doing it in drm_atomic_helper_check_planes() > >>> unconditionally. Easiest solution seems to be to move the call > >>> up to drm_atomic_helper_check(). But as some drivers might want > >>> to use that function without the zpos handling, let's provide > >>> two variants: the normal one, and one that deals with zpos. > >>> > >>> Cc: Marek Szyprowski > >>> Cc: Benjamin Gaignard > >>> Cc: Vincent Abriou > >>> Cc: Laurent Pinchart > >>> Cc: Inki Dae > >>> Cc: Joonyoung Shim > >>> Cc: Seung-Woo Kim > >>> Cc: Kyungmin Park > >>> Cc: Lyude > >>> Cc: Maarten Lankhorst > >>> Cc: stable@vger.kernel.org > >>> Fixes: 44d1240d006c ("drm: add generic zpos property") > >>> Signed-off-by: Ville Syrj�l� > >> > >> Ping. Can I get some buy-in from the relevant folks? > >> > > > > Reviewed-by: Sean Paul > > > > FWIW :) Applied to drm-misc-fixes, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Don't force all planes to be added to the state due to zpos Date: Wed, 26 Oct 2016 18:48:50 +0200 Message-ID: <20161026164850.gkym6bhejosltijc@phenom.ffwll.local> References: <1476101987-31986-1-git-send-email-ville.syrjala@linux.intel.com> <20161025144304.GS4617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Benjamin Gaignard Cc: Sean Paul , Laurent Pinchart , Seung-Woo Kim , dri-devel , Kyungmin Park , stable@vger.kernel.org, Lyude , Vincent Abriou , Marek Szyprowski List-Id: dri-devel@lists.freedesktop.org On Wed, Oct 26, 2016 at 04:09:00PM +0200, Benjamin Gaignard wrote: > I have just tested it on my board, no regression :-) > > Acked-by: Benjamin Gaignard > > 2016-10-25 22:53 GMT+02:00 Sean Paul : > > On Tue, Oct 25, 2016 at 10:43 AM, Ville Syrjälä > > wrote: > >> On Mon, Oct 10, 2016 at 03:19:47PM +0300, ville.syrjala@linux.intel.com wrote: > >>> From: Ville Syrjälä > >>> > >>> We don't want all planes to be added to the state whenever a > >>> plane with fixed zpos gets enabled/disabled. This is true > >>> especially for eg. cursor planes on i915, as we want cursor > >>> updates to go through w/o throttling. Same holds for drivers > >>> that don't support zpos at all (i915 actually falls into this > >>> category right now since we've not yet added zpos support). > >>> > >>> Allow drivers more freedom by letting them deal with zpos > >>> themselves instead of doing it in drm_atomic_helper_check_planes() > >>> unconditionally. Easiest solution seems to be to move the call > >>> up to drm_atomic_helper_check(). But as some drivers might want > >>> to use that function without the zpos handling, let's provide > >>> two variants: the normal one, and one that deals with zpos. > >>> > >>> Cc: Marek Szyprowski > >>> Cc: Benjamin Gaignard > >>> Cc: Vincent Abriou > >>> Cc: Laurent Pinchart > >>> Cc: Inki Dae > >>> Cc: Joonyoung Shim > >>> Cc: Seung-Woo Kim > >>> Cc: Kyungmin Park > >>> Cc: Lyude > >>> Cc: Maarten Lankhorst > >>> Cc: stable@vger.kernel.org > >>> Fixes: 44d1240d006c ("drm: add generic zpos property") > >>> Signed-off-by: Ville Syrjälä > >> > >> Ping. Can I get some buy-in from the relevant folks? > >> > > > > Reviewed-by: Sean Paul > > > > FWIW :) Applied to drm-misc-fixes, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch