From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754873AbcJZXHj (ORCPT ); Wed, 26 Oct 2016 19:07:39 -0400 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:46126 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754265AbcJZXHg (ORCPT ); Wed, 26 Oct 2016 19:07:36 -0400 Date: Thu, 27 Oct 2016 00:07:26 +0100 From: Mel Gorman To: Linus Torvalds Cc: Andy Lutomirski , Andreas Gruenbacher , Peter Zijlstra , Andy Lutomirski , LKML , Bob Peterson , Steven Whitehouse , linux-mm Subject: Re: CONFIG_VMAP_STACK, on-stack struct, and wake_up_bit Message-ID: <20161026230726.GF2699@techsingularity.net> References: <20161026203158.GD2699@techsingularity.net> <20161026220339.GE2699@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2016 at 03:09:41PM -0700, Linus Torvalds wrote: > On Wed, Oct 26, 2016 at 3:03 PM, Mel Gorman wrote: > > > > To be clear, are you referring to PeterZ's patch that avoids the lookup? If > > so, I see your point. > > Yup, that's the one. I think you tested it. In fact, I'm sure you did, > because I remember seeing performance numbers from you ;) > Yeah and the figures were fine. IIRC, 32-bit support was the main thing that was missing but who cares, 32-bit is not going to have the NUMA issues in any way that matters. > So yes, I'd expect my patch on its own to quite possibly regress on > NUMA systems (although I wonder how much), I doubt it's a lot. Even if it does, it's doesn't matter because it's a functional fix. > but I consider PeterZ's > patch the fix to that, so I wouldn't worry about it. > Agreed. Peter, do you plan to finish that patch? -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 594A56B0275 for ; Wed, 26 Oct 2016 19:07:30 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id b80so20350198wme.5 for ; Wed, 26 Oct 2016 16:07:30 -0700 (PDT) Received: from outbound-smtp09.blacknight.com (outbound-smtp09.blacknight.com. [46.22.139.14]) by mx.google.com with ESMTPS id fc4si5198959wjd.5.2016.10.26.16.07.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Oct 2016 16:07:29 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp09.blacknight.com (Postfix) with ESMTPS id 85AAD1C1812 for ; Thu, 27 Oct 2016 00:07:28 +0100 (IST) Date: Thu, 27 Oct 2016 00:07:26 +0100 From: Mel Gorman Subject: Re: CONFIG_VMAP_STACK, on-stack struct, and wake_up_bit Message-ID: <20161026230726.GF2699@techsingularity.net> References: <20161026203158.GD2699@techsingularity.net> <20161026220339.GE2699@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Andy Lutomirski , Andreas Gruenbacher , Peter Zijlstra , Andy Lutomirski , LKML , Bob Peterson , Steven Whitehouse , linux-mm On Wed, Oct 26, 2016 at 03:09:41PM -0700, Linus Torvalds wrote: > On Wed, Oct 26, 2016 at 3:03 PM, Mel Gorman wrote: > > > > To be clear, are you referring to PeterZ's patch that avoids the lookup? If > > so, I see your point. > > Yup, that's the one. I think you tested it. In fact, I'm sure you did, > because I remember seeing performance numbers from you ;) > Yeah and the figures were fine. IIRC, 32-bit support was the main thing that was missing but who cares, 32-bit is not going to have the NUMA issues in any way that matters. > So yes, I'd expect my patch on its own to quite possibly regress on > NUMA systems (although I wonder how much), I doubt it's a lot. Even if it does, it's doesn't matter because it's a functional fix. > but I consider PeterZ's > patch the fix to that, so I wouldn't worry about it. > Agreed. Peter, do you plan to finish that patch? -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org