From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45122 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbcJ0FME (ORCPT ); Thu, 27 Oct 2016 01:12:04 -0400 Date: Thu, 27 Oct 2016 07:12:10 +0200 From: Greg KH To: Russell Currey Cc: stable@vger.kernel.org, Michael Ellerman Subject: Re: [4.4 PATCH] powerpc/eeh: Null check uses of eeh_pe_bus_get Message-ID: <20161027051209.GA30694@kroah.com> References: <20161026231945.29557-1-ruscur@russell.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161026231945.29557-1-ruscur@russell.cc> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Oct 27, 2016 at 10:19:45AM +1100, Russell Currey wrote: > eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE. > Some callers don't check this, and can cause a null pointer dereference > under certain circumstances. > > Fix this by checking NULL everywhere eeh_pe_bus_get() is called. > > Fixes: 8a6b1bc70dbb ("powerpc/eeh: EEH core to handle special event") > Cc: stable@vger.kernel.org # v3.11+ > Signed-off-by: Russell Currey > Reviewed-by: Andrew Donnellan > Signed-off-by: Michael Ellerman > --- > this specific patch for 4.4 only Why? I can't take a "specific patch only" unless you have a whole lot of good description about why, and how, and what, and everything else... Why can't I just take a patch that is already in Linus's tree? Whenever we don't do that, it always (yes really), ends up being wrong. thanks, greg k-h