From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller Date: Thu, 27 Oct 2016 10:32:05 +0100 Message-ID: <20161027093205.GA27135@leverpostej> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: devicetree@vger.kernel.org, Jason Cooper , Marc Zyngier , Kevin Hilman , Linus Walleij , Will Deacon , linux-kernel@vger.kernel.org, Russell King , linux-gpio@vger.kernel.org, Catalin Marinas , Carlo Caione , linux-amlogic@lists.infradead.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Jerome Brunet List-Id: linux-gpio@vger.kernel.org On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > This commit adds the device tree bindings description for Amlogic's GPIO > > interrupt controller available on the meson8, meson8b and gxbb SoC families > > > > Signed-off-by: Jerome Brunet > > --- > > Rob, I did not include the Ack you gave for the RFC as bindings have slightly > > changed. Only the interrupt property has be removed following a discussion I > > had with Marc > > As Mark R already said, you should keep the interrupts property. To be clear, the interrupt routing should be described *somehow*, though I don't think the generic interrupts property is correct, as this is an interrupt *router*, i.e. this device doesn't own the interrupt, it just joins two parts of the line together (and so flags are meaningless). Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031666AbcJ0OVG (ORCPT ); Thu, 27 Oct 2016 10:21:06 -0400 Received: from foss.arm.com ([217.140.101.70]:37704 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942138AbcJ0OUo (ORCPT ); Thu, 27 Oct 2016 10:20:44 -0400 Date: Thu, 27 Oct 2016 10:32:05 +0100 From: Mark Rutland To: Rob Herring Cc: Jerome Brunet , Carlo Caione , Kevin Hilman , Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij , Catalin Marinas , Will Deacon , Russell King Subject: Re: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller Message-ID: <20161027093205.GA27135@leverpostej> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > This commit adds the device tree bindings description for Amlogic's GPIO > > interrupt controller available on the meson8, meson8b and gxbb SoC families > > > > Signed-off-by: Jerome Brunet > > --- > > Rob, I did not include the Ack you gave for the RFC as bindings have slightly > > changed. Only the interrupt property has be removed following a discussion I > > had with Marc > > As Mark R already said, you should keep the interrupts property. To be clear, the interrupt routing should be described *somehow*, though I don't think the generic interrupts property is correct, as this is an interrupt *router*, i.e. this device doesn't own the interrupt, it just joins two parts of the line together (and so flags are meaningless). Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Thu, 27 Oct 2016 10:32:05 +0100 Subject: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller In-Reply-To: <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> Message-ID: <20161027093205.GA27135@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > This commit adds the device tree bindings description for Amlogic's GPIO > > interrupt controller available on the meson8, meson8b and gxbb SoC families > > > > Signed-off-by: Jerome Brunet > > --- > > Rob, I did not include the Ack you gave for the RFC as bindings have slightly > > changed. Only the interrupt property has be removed following a discussion I > > had with Marc > > As Mark R already said, you should keep the interrupts property. To be clear, the interrupt routing should be described *somehow*, though I don't think the generic interrupts property is correct, as this is an interrupt *router*, i.e. this device doesn't own the interrupt, it just joins two parts of the line together (and so flags are meaningless). Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Thu, 27 Oct 2016 10:32:05 +0100 Subject: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller In-Reply-To: <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> Message-ID: <20161027093205.GA27135@leverpostej> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > This commit adds the device tree bindings description for Amlogic's GPIO > > interrupt controller available on the meson8, meson8b and gxbb SoC families > > > > Signed-off-by: Jerome Brunet > > --- > > Rob, I did not include the Ack you gave for the RFC as bindings have slightly > > changed. Only the interrupt property has be removed following a discussion I > > had with Marc > > As Mark R already said, you should keep the interrupts property. To be clear, the interrupt routing should be described *somehow*, though I don't think the generic interrupts property is correct, as this is an interrupt *router*, i.e. this device doesn't own the interrupt, it just joins two parts of the line together (and so flags are meaningless). Thanks, Mark.