From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964872AbcJ1IUr (ORCPT ); Fri, 28 Oct 2016 04:20:47 -0400 Received: from mga04.intel.com ([192.55.52.120]:45010 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936218AbcJ1IUp (ORCPT ); Fri, 28 Oct 2016 04:20:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,557,1473145200"; d="scan'208";a="1077107977" Date: Fri, 28 Oct 2016 11:20:40 +0300 From: Heikki Krogerus To: Andy Shevchenko Cc: Ed Blake , gregkh@linuxfoundation.org, jslaby@suse.com, wangkefeng.wang@huawei.com, noamc@ezchip.com, annie.wang@amd.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, james.hartley@imgtec.com Subject: Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode Message-ID: <20161028082040.GA31275@kuha.fi.intel.com> References: <1477586286-15748-1-git-send-email-ed.blake@imgtec.com> <1477587370.5295.37.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477587370.5295.37.camel@linux.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Thu, Oct 27, 2016 at 07:56:10PM +0300, Andy Shevchenko wrote: > On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote: > > Add a set_ldisc function to enable/disable IrDA SIR mode according to > > the new line discipline. > > Thanks for the patch. > > Consider that not all implementations based on 8250_dw support IRDA > feature. I suppose you need to read capability register bits 6 and 7, > set flag and then based on the value accept or reject IRDA mode. > > P.S. Use -n when prepare patches to link them if you consider them > dependent. These are numbered? Or do you mean that please prefer sending series of patches as threads? % git send-email --thread... Or something like that? I guess coverletter would be nice too. Thanks, -- heikki