From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760326AbcJ1KTi (ORCPT ); Fri, 28 Oct 2016 06:19:38 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33315 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756470AbcJ1KTf (ORCPT ); Fri, 28 Oct 2016 06:19:35 -0400 Date: Fri, 28 Oct 2016 18:19:19 +0800 From: Leo Yan To: Jaehoon Chung Cc: Vincent Guittot , John Stultz , Guodong Xu , Wei Xu , Rob Herring , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "devicetree@vger.kernel.org" , Xinliang Liu , linux-kernel , Fathi Boudra , LAK Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Message-ID: <20161028101919.GA25564@leoy-linaro> References: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org> <20161028072640.GB17266@leoy-linaro> <20161028073830.GC17266@leoy-linaro> <24930ad4-313f-a4f0-c89a-770238863816@samsung.com> <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: [...] > >>> Could you share the log? Is there any log about failure? > >> > >> Sure, please see below log: > > > > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller. > > Maybe hi6220 has handled the reset controller(?)... > > > > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER.. > > Could you check the below thing.. > > /* find reset controller when exist */ > - pdata->rstc = devm_reset_control_get_optional(dev, NULL); > + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset"); > if (IS_ERR(pdata->rstc)) { > if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER) > return ERR_PTR(-EPROBE_DEFER); Confirmed with this fixing, the kernel can bootup successfully. Thanks for this. > To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller? > > > Best Regards, > Jaehoon Chung From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Yan Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Date: Fri, 28 Oct 2016 18:19:19 +0800 Message-ID: <20161028101919.GA25564@leoy-linaro> References: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org> <20161028072640.GB17266@leoy-linaro> <20161028073830.GC17266@leoy-linaro> <24930ad4-313f-a4f0-c89a-770238863816@samsung.com> <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jaehoon Chung Cc: Vincent Guittot , John Stultz , Guodong Xu , Wei Xu , Rob Herring , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Xinliang Liu , linux-kernel , Fathi Boudra , LAK List-Id: devicetree@vger.kernel.org On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: [...] > >>> Could you share the log? Is there any log about failure? > >> > >> Sure, please see below log: > > > > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller. > > Maybe hi6220 has handled the reset controller(?)... > > > > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER.. > > Could you check the below thing.. > > /* find reset controller when exist */ > - pdata->rstc = devm_reset_control_get_optional(dev, NULL); > + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset"); > if (IS_ERR(pdata->rstc)) { > if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER) > return ERR_PTR(-EPROBE_DEFER); Confirmed with this fixing, the kernel can bootup successfully. Thanks for this. > To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller? > > > Best Regards, > Jaehoon Chung -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: leo.yan@linaro.org (Leo Yan) Date: Fri, 28 Oct 2016 18:19:19 +0800 Subject: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com> References: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org> <20161028072640.GB17266@leoy-linaro> <20161028073830.GC17266@leoy-linaro> <24930ad4-313f-a4f0-c89a-770238863816@samsung.com> <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com> Message-ID: <20161028101919.GA25564@leoy-linaro> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: [...] > >>> Could you share the log? Is there any log about failure? > >> > >> Sure, please see below log: > > > > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller. > > Maybe hi6220 has handled the reset controller(?)... > > > > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER.. > > Could you check the below thing.. > > /* find reset controller when exist */ > - pdata->rstc = devm_reset_control_get_optional(dev, NULL); > + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset"); > if (IS_ERR(pdata->rstc)) { > if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER) > return ERR_PTR(-EPROBE_DEFER); Confirmed with this fixing, the kernel can bootup successfully. Thanks for this. > To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller? > > > Best Regards, > Jaehoon Chung