All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas@biessmann.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 6/7] usb: ehci-atmel: Remove unnecessary clock calling
Date: Fri, 28 Oct 2016 12:37:30 +0200	[thread overview]
Message-ID: <20161028103730.l6od35bf7tymhea4@mba.local> (raw)
In-Reply-To: <1474945234-30540-7-git-send-email-wenyou.yang@atmel.com>

On Tue, Sep 27, 2016 at 11:00:33AM +0800, Wenyou Yang wrote:
> Due to the peripheral clock driver improvement, remove the
> unnecessary clock calling.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

Reviewed-by: Andreas Bie?mann <andreas@biessmann.org>

> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/usb/host/ehci-atmel.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 2b138c5..a5c6d34 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -56,9 +56,7 @@ struct ehci_atmel_priv {
>  
>  static int ehci_atmel_enable_clk(struct udevice *dev)
>  {
> -	struct udevice *dev_clk;
>  	struct clk clk;
> -	int periph;
>  	int ret;
>  
>  	ret = clk_get_by_index(dev, 0, &clk);
> @@ -73,19 +71,6 @@ static int ehci_atmel_enable_clk(struct udevice *dev)
>  	if (ret)
>  		return -EINVAL;
>  
> -	periph = fdtdec_get_uint(gd->fdt_blob, clk.dev->of_offset, "reg", -1);
> -	if (periph < 0)
> -		return -EINVAL;
> -
> -	dev_clk = dev_get_parent(clk.dev);
> -	if (!dev_clk)
> -		return -ENODEV;
> -
> -	ret = clk_request(dev_clk, &clk);
> -	if (ret)
> -		return ret;
> -
> -	clk.id = periph;
>  	ret = clk_enable(&clk);
>  	if (ret)
>  		return ret;

  reply	other threads:[~2016-10-28 10:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27  3:00 [U-Boot] [PATCH v3 0/7] clk: at91: Improve the clock implementation Wenyou Yang
2016-09-27  3:00 ` [U-Boot] [PATCH v3 1/7] clk: clk-uclass: Assign clk->dev before call .of_xlate Wenyou Yang
2016-09-27 17:55   ` Simon Glass
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2016-09-27  3:00 ` [U-Boot] [PATCH v3 2/7] clk: at91: Improve the clock implementation Wenyou Yang
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2016-09-27  3:00 ` [U-Boot] [PATCH v3 3/7] gpio: atmel_pio4: Remove unnecessary clock calling Wenyou Yang
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2016-09-27  3:00 ` [U-Boot] [PATCH v3 4/7] i2c: at91_i2c: " Wenyou Yang
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2016-09-27  3:00 ` [U-Boot] [PATCH v3 5/7] i2c: at91_i2c: Change error return -ENODEV to -EINVAL Wenyou Yang
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2016-09-27  3:00 ` [U-Boot] [PATCH v3 6/7] usb: ehci-atmel: Remove unnecessary clock calling Wenyou Yang
2016-10-28 10:37   ` Andreas Bießmann [this message]
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2016-09-27  3:00 ` [U-Boot] [PATCH v3 7/7] mmc: atmel_sdhci: " Wenyou Yang
2016-10-28 16:49   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028103730.l6od35bf7tymhea4@mba.local \
    --to=andreas@biessmann.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.