[PATCH 1/1] nvdimm: use the right length of "pmem"

[PATCH 1/1] nvdimm: use the right length of "pmem"

[Nicolas Iooss]

In order to test that the name of a resource begins with "pmem", call
strncmp() with 4 as length instead of 3 to match the whole prefix.

Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
for multi-pmem")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 drivers/nvdimm/label.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index fac7cabe8f56..dd615345699f 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
@@ -938,7 +938,7 @@ int nd_pmem_namespace_label_update(struct nd_region *nd_region,
 		}
 
 		for_each_dpa_resource(ndd, res)
-			if (strncmp(res->name, "pmem", 3) == 0)
+			if (strncmp(res->name, "pmem", 4) == 0)
 				count++;
 		WARN_ON_ONCE(!count);
 
-- 
2.10.1

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

[PATCH 1/1] nvdimm: use the right length of "pmem"

[Nicolas Iooss]

In order to test that the name of a resource begins with "pmem", call
strncmp() with 4 as length instead of 3 to match the whole prefix.

Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
for multi-pmem")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 drivers/nvdimm/label.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index fac7cabe8f56..dd615345699f 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
@@ -938,7 +938,7 @@ int nd_pmem_namespace_label_update(struct nd_region *nd_region,
 		}
 
 		for_each_dpa_resource(ndd, res)
-			if (strncmp(res->name, "pmem", 3) == 0)
+			if (strncmp(res->name, "pmem", 4) == 0)
 				count++;
 		WARN_ON_ONCE(!count);
 
-- 
2.10.1

Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

[Dan Williams]

On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
<nicolas.iooss_linux@m4x.org> wrote:
> In order to test that the name of a resource begins with "pmem", call
> strncmp() with 4 as length instead of 3 to match the whole prefix.
>
> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
> for multi-pmem")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Thanks, although I would not call this out as a fix since the length
parameter could be 1 and still do the right thing.  I.e. we're
distinguishing "blk" from "pmem" resources.  I'll add this for 4.10 as
a cleanup.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

[Dan Williams]

On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
<nicolas.iooss_linux@m4x.org> wrote:
> In order to test that the name of a resource begins with "pmem", call
> strncmp() with 4 as length instead of 3 to match the whole prefix.
>
> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
> for multi-pmem")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Thanks, although I would not call this out as a fix since the length
parameter could be 1 and still do the right thing.  I.e. we're
distinguishing "blk" from "pmem" resources.  I'll add this for 4.10 as
a cleanup.

Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

[Nicolas Iooss]

On 30/10/16 16:50, Dan Williams wrote:
> On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
> <nicolas.iooss_linux@m4x.org> wrote:
>> In order to test that the name of a resource begins with "pmem", call
>> strncmp() with 4 as length instead of 3 to match the whole prefix.
>>
>> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
>> for multi-pmem")
>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> 
> Thanks, although I would not call this out as a fix since the length
> parameter could be 1 and still do the right thing.  I.e. we're
> distinguishing "blk" from "pmem" resources.  I'll add this for 4.10 as
> a cleanup.

All right. Thanks for your quick reply!

Nicolas
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 1/1] nvdimm: use the right length of "pmem"

[Nicolas Iooss]

On 30/10/16 16:50, Dan Williams wrote:
> On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
> <nicolas.iooss_linux@m4x.org> wrote:
>> In order to test that the name of a resource begins with "pmem", call
>> strncmp() with 4 as length instead of 3 to match the whole prefix.
>>
>> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
>> for multi-pmem")
>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> 
> Thanks, although I would not call this out as a fix since the length
> parameter could be 1 and still do the right thing.  I.e. we're
> distinguishing "blk" from "pmem" resources.  I'll add this for 4.10 as
> a cleanup.

All right. Thanks for your quick reply!

Nicolas