All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ALSA: bebob: use the right string length in check_audiophile_booted()
@ 2016-10-29 11:41 Nicolas Iooss
  0 siblings, 0 replies; only message in thread
From: Nicolas Iooss @ 2016-10-29 11:41 UTC (permalink / raw)
  To: Clemens Ladisch, Takashi Sakamoto, alsa-devel; +Cc: linux-kernel, Nicolas Iooss

Function check_audiophile_booted() only compares 15 characters of the
24-character-long string "FW Audiophile Bootloader" with the firmware
model name. As this seems to be incorrect and because there is no
comment explaining this "15", fix the length which is used in strncmp().

This patch has only been compile-tested.

Fixes: 9076c22ddd9d ("ALSA: bebob: Add support for M-Audio usual
Firewire series")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 sound/firewire/bebob/bebob.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c
index 3469ac14c89c..b23cd0901553 100644
--- a/sound/firewire/bebob/bebob.c
+++ b/sound/firewire/bebob/bebob.c
@@ -177,7 +177,7 @@ check_audiophile_booted(struct fw_unit *unit)
 	if (fw_csr_string(unit->directory, CSR_MODEL, name, sizeof(name)) < 0)
 		return false;
 
-	return strncmp(name, "FW Audiophile Bootloader", 15) != 0;
+	return strncmp(name, "FW Audiophile Bootloader", 24) != 0;
 }
 
 static void
-- 
2.10.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-29 11:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-29 11:41 [PATCH 1/1] ALSA: bebob: use the right string length in check_audiophile_booted() Nicolas Iooss

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.