From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757703AbcJaBix (ORCPT ); Sun, 30 Oct 2016 21:38:53 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:34434 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304AbcJaBiv (ORCPT ); Sun, 30 Oct 2016 21:38:51 -0400 Date: Sun, 30 Oct 2016 20:38:48 -0500 From: Rob Herring To: Jonathan Richardson Cc: Srinivas Kandagatla , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Scott Branden , Ray Jui , bcm-kernel-feedback-list@broadcom.com, Jonathan Richardson , Scott Branden , Oza Pawandeep Subject: Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver Message-ID: <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> References: <1477336324-10543-1-git-send-email-jonathan.richardson@broadcom.com> <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: > From: Jonathan Richardson > > Reviewed-by: Ray Jui > Tested-by: Jonathan Richardson > Signed-off-by: Scott Branden > Signed-off-by: Oza Pawandeep > Signed-off-by: Jonathan Richardson > --- > Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt > new file mode 100644 > index 0000000..6462e12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt > @@ -0,0 +1,17 @@ > +Broadcom OTP memory controller > + > +Required Properties: > +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used > + in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second > + generation Broadcom OTPC which is used in SoC's such as Stingray and supports > + 64-bit read/write. These should be SoC specific. While I'd guess this block is simple enough, having the SoC can define what all the bits are. Yes, there is a binding to define those, but you may not use that. > +- reg: Base address of the OTP controller. > +- brcm,ocotp-size: Amount of memory available, in 32 bit words > + > +Example: > + > +otp: otp@0301c800 { > + compatible = "brcm,ocotp"; > + reg = <0x0301c800 0x2c>; > + brcm,ocotp-size = <2048>; > +}; > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Sun, 30 Oct 2016 20:38:48 -0500 Subject: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver In-Reply-To: <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> References: <1477336324-10543-1-git-send-email-jonathan.richardson@broadcom.com> <1477336324-10543-2-git-send-email-jonathan.richardson@broadcom.com> Message-ID: <20161031013848.4vi2544tb5cs65nk@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote: > From: Jonathan Richardson > > Reviewed-by: Ray Jui > Tested-by: Jonathan Richardson > Signed-off-by: Scott Branden > Signed-off-by: Oza Pawandeep > Signed-off-by: Jonathan Richardson > --- > Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt > new file mode 100644 > index 0000000..6462e12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt > @@ -0,0 +1,17 @@ > +Broadcom OTP memory controller > + > +Required Properties: > +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used > + in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second > + generation Broadcom OTPC which is used in SoC's such as Stingray and supports > + 64-bit read/write. These should be SoC specific. While I'd guess this block is simple enough, having the SoC can define what all the bits are. Yes, there is a binding to define those, but you may not use that. > +- reg: Base address of the OTP controller. > +- brcm,ocotp-size: Amount of memory available, in 32 bit words > + > +Example: > + > +otp: otp at 0301c800 { > + compatible = "brcm,ocotp"; > + reg = <0x0301c800 0x2c>; > + brcm,ocotp-size = <2048>; > +}; > -- > 1.9.1 >