From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c12Tu-0005jr-Va for qemu-devel@nongnu.org; Sun, 30 Oct 2016 22:37:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c12Ts-0005XT-4z for qemu-devel@nongnu.org; Sun, 30 Oct 2016 22:37:51 -0400 Date: Mon, 31 Oct 2016 13:34:47 +1100 From: David Gibson Message-ID: <20161031023447.GG18226@umbus.fritz.box> References: <1477675084-7713-1-git-send-email-joserz@linux.vnet.ibm.com> <1477675084-7713-5-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m972NQjnE83KvVa/" Content-Disposition: inline In-Reply-To: <1477675084-7713-5-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 4/4] target-ppc: Implement bcdctz. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --m972NQjnE83KvVa/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2016 at 03:18:04PM -0200, Jose Ricardo Ziviani wrote: > bcdctz. converts from BCD to Zoned numeric format. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 51 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 7 +++-- > 3 files changed, 57 insertions(+), 2 deletions(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index a9ac28b..489a405 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -374,6 +374,7 @@ DEF_HELPER_4(bcdsub, i32, avr, avr, avr, i32) > DEF_HELPER_3(bcdcfn, i32, avr, avr, i32) > DEF_HELPER_2(bcdctn, i32, avr, avr) > DEF_HELPER_3(bcdcfz, i32, avr, avr, i32) > +DEF_HELPER_3(bcdctz, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 19e6a3a..518824e 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2774,6 +2774,57 @@ uint32_t helper_bcdcfz(ppc_avr_t *r, ppc_avr_t *b,= uint32_t ps) > =20 > return cr; > } > + > +uint32_t helper_bcdctz(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + int i; > + int j; > + int cr =3D 0; > + uint8_t digit =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + int zone_lead =3D (ps) ? 0xF0 : 0x30; > + int invalid =3D (sgnb =3D=3D 0); > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + > + int eq_flag =3D (b->u64[HI_IDX] =3D=3D 0) && ((b->u64[LO_IDX] >> 4) = =3D=3D 0); > + int ox_flag =3D ((b->u64[HI_IDX] >> 4) !=3D 0); > + > + for (i =3D 0, j =3D 1; i < 32; i +=3D 2, j++) { > + digit =3D bcd_get_digit(b, j, &invalid); > + > + if (unlikely(invalid)) { > + break; > + } > + > + ret.u8[BCD_DIG_BYTE(i)] =3D zone_lead + digit; > + } > + > + if (ps) { > + bcd_put_digit(&ret, (sgnb =3D=3D 1) ? 0xC : 0xD, 1); > + } else { > + bcd_put_digit(&ret, (sgnb =3D=3D 1) ? 0x3 : 0x7, 1); > + } > + bcd_put_digit(&ret, b->u8[BCD_DIG_BYTE(0)] >> 4, 0); This last bcd_put_digit looks unneccessary - your loop above has already put all the actual digits into the output, and writing the sign nibble won't have overwritten that. > + > + if (!eq_flag) { > + cr =3D (sgnb =3D=3D 1) ? 1 << CRF_GT : 1 << CRF_LT; > + } else { > + cr =3D 1 << CRF_EQ; > + } > + > + if (ox_flag) { > + cr |=3D 1 << CRF_SO; > + } > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + *r =3D ret; > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 6e54437..a868740 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -992,6 +992,7 @@ GEN_BCD(bcdsub) > GEN_BCD2(bcdcfn) > GEN_BCD3(bcdctn) > GEN_BCD2(bcdcfz) > +GEN_BCD2(bcdctz) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -1001,7 +1002,8 @@ static void gen_xpnd04_1(DisasContext *ctx) > case 2: > break; /* bcdcfsq. */ > case 4: > - break; /* bcdctz. */ > + gen_bcdctz(ctx); > + break; > case 5: > gen_bcdctn(ctx); > break; > @@ -1026,7 +1028,8 @@ static void gen_xpnd04_2(DisasContext *ctx) > case 2: > break; /* bcdcfsq. */ > case 4: > - break; /* bcdctz. */ > + gen_bcdctz(ctx); > + break; > case 6: > gen_bcdcfz(ctx); > break; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --m972NQjnE83KvVa/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYFq3HAAoJEGw4ysog2bOS/JcQAJL1zzrlMorCDkB/KnSxII0j cJg2PtpZrA7uvw3lJN97waSQn4eARdpBabUFqiBpYnXORyJOYpijER1s/k6OL5Dr EFzGba+1ArBtCp62zq6E9mII9PSSDuH+p3aeeNdTirMHOl/uB92z28ebBbA4Ajka IGHVgDk824+CgtklwgPEaxaHbSoAEqfEA1c2KmSDydF5SWCzESIArrgzdV0DvzOy pCg8BE+rCLICtneP8QQkRYhW5/VtoGWC3vVVM6CPRaXOn9kRb6VBKX2DHMKQUJF8 uiPvEZZ1vRNi6yvh5lYMYP7OixUPzuorcZlJ2lRwkZ7WsJeJcciNlpv8T7hdz6FR y+k6eNjaqSZRVceBLHY5IW+TYYFiV2rXxVdLZ6OygF60Dqz/POMr8z7i6Uif1wWb KF//8c3N7Y947wwsOfyEl91EUmTviSFX1dzsUxbtOreLCQp0SOxMQk20kYhvvWgu /Iyw1XFrJ4Ej9/4Q4iaBME7qlLYo6WPHe0FsuQlwkejHTJ+J/aMbdnFwb8z6BDqD 77vaV4J3S3ezCphJ9z90nOC5atj7YrUkoxn88G9Py8pWSsVD3VJC/c4sQWJPAnXx 49+P34TgeCuCDLkXI9eqCvUl5oZ4lW5pAGiE0bA2YAAKv/VXiVtwZcRsTJvwZEwv kfK7BF+6TgBjup0cczN4 =dbr5 -----END PGP SIGNATURE----- --m972NQjnE83KvVa/--