All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Hui Chun Ong <hui.chun.ong@ni.com>,
	rpurdie@rpsys.net, linux-leds@vger.kernel.org,
	jonathan.hearn@ni.com, julia.cartwright@ni.com,
	Brad Mouring <brad.mouring@ni.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v2] leds: Add user LED driver for NIC78bx device
Date: Mon, 31 Oct 2016 10:47:04 +0200	[thread overview]
Message-ID: <20161031084704.GI23812@lahna.fi.intel.com> (raw)
In-Reply-To: <d61aa980-9519-df29-6fef-cc6e4ac182d6@samsung.com>

On Fri, Oct 28, 2016 at 12:08:57PM +0200, Jacek Anaszewski wrote:
> > +static struct platform_driver led_driver = {
> > +	.probe = ni78bx_add,
> > +	.remove = ni78bx_remove,
> > +	.driver = {
> > +		.name = KBUILD_MODNAME,
> > +		.acpi_match_table = ACPI_PTR(led_device_ids),
> 
> Please CC ACPI maintainers always if you include acpi.h
> Cc Rafael and Mika.

>From ACPI perspective this driver looks fine to me now.

  reply	other threads:[~2016-10-31  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161027110331epcas3p332bf735529a71e5c5efa66adf4312785@epcas3p3.samsung.com>
2016-10-27 11:02 ` [PATCH v2] leds: Add user LED driver for NIC78bx device Hui Chun Ong
2016-10-28 10:08   ` Jacek Anaszewski
2016-10-31  8:47     ` Mika Westerberg [this message]
2016-11-02  8:22       ` Jacek Anaszewski
2016-11-02 10:00         ` Mika Westerberg
2016-11-01  8:23     ` Hui Chun Ong
2016-11-01 17:48       ` Jacek Anaszewski
2016-11-03 14:43         ` Hui Chun Ong
2016-11-03 16:02           ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031084704.GI23812@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=brad.mouring@ni.com \
    --cc=hui.chun.ong@ni.com \
    --cc=j.anaszewski@samsung.com \
    --cc=jonathan.hearn@ni.com \
    --cc=julia.cartwright@ni.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.