From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932452AbcJaKlb (ORCPT ); Mon, 31 Oct 2016 06:41:31 -0400 Received: from mga09.intel.com ([134.134.136.24]:16995 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765275AbcJaKla (ORCPT ); Mon, 31 Oct 2016 06:41:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,426,1473145200"; d="scan'208";a="1078379974" Date: Mon, 31 Oct 2016 12:41:25 +0200 From: Mika Westerberg To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Linus Walleij , Hans de Goede , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] Input: gpio_keys_polled - keep button data constant Message-ID: <20161031104125.GK23812@lahna.fi.intel.com> References: <1477696485-6995-1-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477696485-6995-1-git-send-email-dmitry.torokhov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 28, 2016 at 04:14:39PM -0700, Dmitry Torokhov wrote: > diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h > index ee2d8c6..d1250ad 100644 > --- a/include/linux/gpio_keys.h > +++ b/include/linux/gpio_keys.h > @@ -2,7 +2,6 @@ > #define _GPIO_KEYS_H > > struct device; > -struct gpio_desc; > > /** > * struct gpio_keys_button - configuration parameters > @@ -31,7 +30,6 @@ struct gpio_keys_button { > bool can_disable; > int value; > unsigned int irq; > - struct gpio_desc *gpiod; Please remove the kernel-doc comment of this member as well. > };