From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c1srV-0004KA-Lu
	for qemu-devel@nongnu.org; Wed, 02 Nov 2016 06:33:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c1srV-0004sZ-0K
	for qemu-devel@nongnu.org; Wed, 02 Nov 2016 06:33:41 -0400
Date: Wed, 2 Nov 2016 11:33:31 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20161102103331.GC6182@noname.redhat.com>
References: <1477937214-20899-1-git-send-email-ashijeetacharya@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1477937214-20899-1-git-send-email-ashijeetacharya@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused
 parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: mreitz@redhat.com, rjones@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
> This patch drops the unused parameter "BDRVSSHState" being passed into
> the ssh_config() function and fixes the bug.
> 
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>

The patch looks good, but why do claim that this is a bug fix rather
than just a code cleanup?

Kevin