All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 2/5] testsuite: make tests known to fail effectively fail
Date: Wed,  2 Nov 2016 22:45:06 +0100	[thread overview]
Message-ID: <20161102214509.36571-3-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20161102214509.36571-1-luc.vanoostenryck@gmail.com>

These tests must fail because some errors which should
be detected are not.
But the test suite lack to see that because those tests
don't have the check-error-start/end section.

Add such a section (with madeup error message) so that the
testsuite now properly see and report the failure.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 validation/badtype1.c   | 4 ++++
 validation/struct-ns2.c | 6 ++++++
 2 files changed, 10 insertions(+)

diff --git a/validation/badtype1.c b/validation/badtype1.c
index ced7f9f1..b15cb50e 100644
--- a/validation/badtype1.c
+++ b/validation/badtype1.c
@@ -3,4 +3,8 @@ static void foo(enum bar baz);
 /*
  * check-name: enum not in scope
  * check-known-to-fail
+ *
+ * check-error-start
+badtype1.c:1:22: warning: bad scope for 'enum bar'
+ * check-error-end
  */
diff --git a/validation/struct-ns2.c b/validation/struct-ns2.c
index 4dd2c3bf..c5afbb71 100644
--- a/validation/struct-ns2.c
+++ b/validation/struct-ns2.c
@@ -16,4 +16,10 @@ h (void)
 /*
  * check-name: struct not in scope
  * check-known-to-fail
+ *
+ * check-error-start
+struct-ns2.c:2:11: warning: bad scope for 'struct Bar'
+struct-ns2.c:12:14: error: incomplete type/unknown size for 'y'
+struct-ns2.c:13:5: error: using member 'i' in incomplete 'struct Bar'
+ * check-error-end
  */
-- 
2.10.1


  parent reply	other threads:[~2016-11-02 21:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 21:45 [PATCH 0/5] tests & testsuite small improvements Luc Van Oostenryck
2016-11-02 21:45 ` [PATCH 1/5] testsuite: give a proper name to the 'binary-constant' test Luc Van Oostenryck
2016-11-17 10:19   ` Christopher Li
2016-11-02 21:45 ` Luc Van Oostenryck [this message]
2016-11-17 14:16   ` [PATCH 2/5] testsuite: make tests known to fail effectively fail Christopher Li
2016-11-02 21:45 ` [PATCH 3/5] testsuite: report as error tests known to fail but which succeed Luc Van Oostenryck
2016-11-17 16:13   ` Christopher Li
2016-11-18 12:52     ` Luc Van Oostenryck
2016-11-19  0:44     ` Luc Van Oostenryck
2016-11-20  1:43       ` Christopher Li
2016-11-02 21:45 ` [PATCH 4/5] testsuite: simplify the ioc-typecheck case Luc Van Oostenryck
2016-11-17 16:17   ` Christopher Li
2016-11-02 21:45 ` [PATCH 5/5] testsuite: add a simple test for -Wenum-mismatch Luc Van Oostenryck
2016-11-17 16:25   ` Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161102214509.36571-3-luc.vanoostenryck@gmail.com \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.