From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 1/6] lib/x86/vm: collection of
 improvements
Date: Thu, 3 Nov 2016 11:42:36 +0100
Message-ID: <20161103104236.z2dklvlnsmzkdktn@kamzik.brq.redhat.com>
References: <1478119966-13252-1-git-send-email-drjones@redhat.com>
 <1478119966-13252-2-git-send-email-drjones@redhat.com>
 <7a0f1a1a-59a4-9fba-cdfe-985d18cf0be4@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, thuth@redhat.com
To: Laurent Vivier <lvivier@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46972 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750839AbcKCKml (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 3 Nov 2016 06:42:41 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id 4D62DC04B30A
        for <kvm@vger.kernel.org>; Thu,  3 Nov 2016 10:42:40 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <7a0f1a1a-59a4-9fba-cdfe-985d18cf0be4@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 03, 2016 at 10:40:14AM +0100, Laurent Vivier wrote:
> >  void *alloc_page()
> >  {
> >      void *p;
> >  
> > +    spin_lock(&heap_lock);
> > +
> >      if (!free)
> > -	return 0;
> > +	return NULL;
> 
> You must unlock heap_lock before return

Doh! Nice catch!

Thanks,
drew