From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935622AbcKDPRx (ORCPT ); Fri, 4 Nov 2016 11:17:53 -0400 Received: from mail-bn3nam01on0080.outbound.protection.outlook.com ([104.47.33.80]:18144 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934358AbcKDPRv (ORCPT ); Fri, 4 Nov 2016 11:17:51 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yazen.Ghannam@amd.com; Date: Fri, 4 Nov 2016 10:44:47 -0400 From: Yazen Ghannam To: Borislav Petkov CC: LKML , X86 ML Subject: Re: [PATCH 1/3] x86/RAS: Simplify SMCA bank descriptor struct Message-ID: <20161104144446.GA20663@yaz-fedora.dyhomenet> References: <20161103125556.15482-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161103125556.15482-1-bp@alien8.de> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [73.35.89.163] X-ClientProxiedBy: DM5PR18CA0037.namprd18.prod.outlook.com (10.173.208.23) To DM5PR12MB1386.namprd12.prod.outlook.com (10.168.238.137) X-MS-Office365-Filtering-Correlation-Id: 409439ed-0da9-4e43-6998-08d404c122b9 X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;2:aRh+OKj7O9gwDi9RTMiZdMasJikUxXc24btYbTsEBtvTkgMYTQEY5VgIKeeJxhzL2xUhScwimLelgTtG4kOI/U7BQfu1xK3rf8b0KiGzVJvZGVHfvD5l+8SaMz7b6WPX1FB0uIyHHYTiRbrDdLp011fi5nCesTQkOqpRAMzNGQTpS3SNSEkHvLTdBTG7dF3W7KTWE3I57pshXxnp/O4+Yw==;3:xs/ebSXtJldpYYCrw4KpyOgyjP36RdzkS0olPME5m+eD0uYdNxYz73bEkoDpsfg35KW4En4Cq9CLINUoPciWlkUUQlXKRRuKFb83D4/KcLXeXU2VCOIFE2asDxcvtcGkb+2VakSit1lQ+2ZwIV7EYQ==;25:szwtZPI+ATKzTm46+lMofA2pvYbeSHaNmxoIz/aK0Ybt92AUz1nXzbwlaEJuVDIhWcGjCDM8t0ZN6ngt56MFXvbdzIMvYcyRBauQjs/6jqKAJaBVA6rc+9yAyK/RMmoWPltBJF6CYY+m8B2KpbjovCYXsFcGAvJUKabnd04w6/rTjeTNZIWxydYgP33mrUDkpStpRAJQWbFJVcW1xjfnDaM31oNe525vJKz1+BCWM/SVFKMrUtKjQeL7FBru+kw4TbwS+zRohD9G/3s8/0OSnKYmjAkILZein6jP+ASiwRqEqgJ8p2qbn0qX9Zdzrgo9VGV95VcAUAQno9S0yX0rHJ+NvYonHCCSvWMwjJfi6/3WaSkl5MoRMA38GxOHVj8KDlVsf9tE4pX8cosS4g1f17Q+0afRuesNA5k7zQK99fE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1386; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;31:6IV0iGihjKa2kRqFxBQL3b/zcfot9zrLmVlb5xdQQhrNbxQSba00e489/CvcrKKxhIYZ9gXJMAfrRpcE3s/MW2qioKvqL1smmxn8FVbYlD07PXEKwbwyjkv+Ou5YaM95TQF4E/9lg1CrJORkGwW21lhHxlzO2gb8IcWpbbhyzA6eG/gEF8nFQPHn9gFrZjcWe5g5fj6nac/DAECFs111cEfXiM+Y0Wnlu/WxoleDqDvA99XbOBv9PnEwpWSf0+l2;20:LNu7QBCCJqfI8LdYylA1OsJ9ty4+5ASRlyg+qFLilMHlQn/0BhUaH9yHbHT9RgR/DcVN/AWxvzyCRaJnnp5BUQVz2913oxyLRTf1NO5rjZV2CdGjxN2LHkeLNVrTAJx2s/91ZcIo1QYP4uVxI6WzmGGMNBVW68KP6haWqztSQdjfQBS55gj/PYyseOTo+wWFDT5efPdOqLSMU/0aixfFhqqDZNcnx15Ah0mwBLVK064EwZyfTIeG09IxYs3LY2efqNt39/xrdTYBNwh/h0JPvjHC6F6HlF7qax+BFaeNF4IswtMTMhmN4rwaNwPiJwfs7uBbGPRGdnuNZ9RIa73aamj+UgkIFN7PsyS9C/pCsl+G1fCAJJpxaKFeOZzgY6aqHRfU6jgBd+Ia9zGvW33H/vZuEYS32sSeJzfZ61w/+DtJlAa2OcaHN20uo2zjUO8jx1sPrjhXfwS79hFc8O0FS+fneJE+F4SkN8auivGRwcZHCs8IH7cjQEI20JgZjWQU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DM5PR12MB1386;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1386; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;4:ECU6OxfnZBmO/3PkhHrZgTKqPAuvdchpmEfD3UaDLo4LLtao579+ggPf7TuqQrX4YY6FPVpUuFSQPrslR9N3B3gvZq50/rLrGSsze5CD/A6R9B3yU8ASLulAfG/VwDyjszAhV4uTpPw4toyw3Ic3Ot5pt1jQX8wBPmK0iv/6+Tf2EHVZic259/Pam9AjnwCqd8mow4AoCTgl6dTtV1nuCiK4rIHTHDuagY4GKfIWxSjAIX8scV8uML2UAKIapAHCerAqrMDc83oZTp0XgMCHlE/sSe0YTGKkCZnF9B3PYtAiyMesU6XoMzBm1WkWUpyYy39y30wcoLt1YgrLnaMRkgdnV0h876OzC1Gp2Ru+5GBzJHL2zvAXWxE6dcHgqSpiWGNPdaYCfqd56EUq2R6xUA/KBiT961Mqp2r9uWQx7R0A5R/zHjfAWPtCMUf/rmd2oLZ7K6AXRk98umEySDXCAw== X-Forefront-PRVS: 01165471DB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(47776003)(101416001)(33656002)(54356999)(189998001)(86362001)(4001350100001)(76176999)(50986999)(106356001)(105586002)(42186005)(97736004)(2950100002)(46406003)(6916009)(6666003)(50466002)(9686002)(68736007)(2906002)(305945005)(6116002)(586003)(77096005)(7846002)(81166006)(1076002)(5660300001)(23726003)(66066001)(92566002)(83506001)(558084003)(4326007)(81156014)(8676002)(7736002)(110136003)(19580395003)(19580405001)(97756001)(3846002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1386;H:yaz-fedora.dyhomenet;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR12MB1386;23:9NV0agBMW86FOGNufFJSE4kJQkfQvCW4yMGyvQ7uo?= =?us-ascii?Q?TqTt1CHuIu41Viw8R6OoacNiZA/WtBOKEVUlQZG64npRi/0g7DsC4RdlXR1p?= =?us-ascii?Q?RSj7YJFrjGlyFZEEOC7BIayIUh6wjfD1calJk39a09V2DdPHIJi4xQd906fc?= =?us-ascii?Q?PHlXhhw5LVjWunzDTiE6IUhpPRGYy8yKCftfpO+05qwaFfiporzPaqVLuoim?= =?us-ascii?Q?UA5+/aEWgUdd7fJg2n61mrBCnTpehNMAHJmz+mh406K+IrqM5SaQb0gWVig0?= =?us-ascii?Q?mIQlm+gQwxCtQbnSCUmEiPuURQlakk2pFawO1Xp98SSaziTOdRsUSOQLAGS5?= =?us-ascii?Q?+053SkFb7ceX/lZScm6/GKXq9nfZ2NwtENDfPcCuV615gpOQOgZPCxjGSeC9?= =?us-ascii?Q?Le2P13IKgH49NjvxA//HcNJuBqhGwv4x1l0VwmdbcplBOisRZ1k1I5wfjaeG?= =?us-ascii?Q?CXh/l6epbQ287mV3ICqQV4vUNTSJvjh5sTQbEtpg3v3PMKVeUbJc8/CNElxi?= =?us-ascii?Q?Yu5lhS4KjgiKFiASx/sCZvWIg0KmiiXe9O8SOT1m2j8feRo6pDLiazv9PqVK?= =?us-ascii?Q?RVgbOYqa3pCocsxAFQP+h5+TVzzRKmOsU7oinpX+2PqKyVgpNjg5j1tmvtwb?= =?us-ascii?Q?Xgv4PW5RkgKdrkxDpomT85nC07o+CUpuDW73AsZoveTV/viyzH6hdjcJ1sEb?= =?us-ascii?Q?s2+I/hZ5FRYGcRYlusxA2hBdG6Vo9MCFXIMOA2R9vLm8rJZf7VQmIXCG8W1f?= =?us-ascii?Q?jqYrrNmnQkVwY/9f038eFRVsC51hHFv53c4x7pwt68GHaD9mjQHTAPqR3+Hv?= =?us-ascii?Q?A28F27rAnDRcnWSddt9Hc08M57pClseh6heSMODLsTEY+MrT5B9rgVDwA+Uf?= =?us-ascii?Q?fezewIDU/U6sG0xHlwCXXiDo4glwUbbGtDHXgadlobvHaWhH+z2EJddwj+rV?= =?us-ascii?Q?Ka0xhFl/s+SsS6Eccmn1nja6uIFv7qm1+6PAaLv9wLAfb8NA9ToZzAiE4bzO?= =?us-ascii?Q?qmuXsI3SWwU42zJl69dNPeqVgqI1PQU5bBnAY8xL2I8RgwEs6JJBWVbNzgwm?= =?us-ascii?Q?XsuaOqh1h/BccxCNH39ExWzd+e2COmhhxIo9SOBC6mGh12rJFlJjQ/8Sb0M2?= =?us-ascii?Q?z8/+uQT1kQ2v2FxH2S7Bl6dLo8zy08NikypL9QsPHWcDY+CG8nacahjRjo8V?= =?us-ascii?Q?bZAMzbIi3Gq8NuISHvrh/5BkI2/XuNuU3t2Erf1Q99WnIkKfHVu+Uhlrw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;6:45cSiaAXi45pYXXOZmpZCn8vlBkZ2gAag1HHijsLi+8KJ1f7wN3kPBRYlJAyWzUzqOk5Q4tVEIffv+pRMud1bOeoXX+DGs5eUGJ6rTMcCyJUv/Jp6Nxn4XMi1g2D/6kWW458NWcIP3JhmIjT9LOHNuOYw8jm32Gn1mkItjhr7Bnn2ioK1YtPc5F2a4I6wMr2gikDFjAUynsfKJ+7QAiWbIzHnq4TthbCBLmeOOfxiG7G6SOTBVOgCOJMl/GBiodjAd/XZDgbtnk7E8lYqTpl65wwJMwHT2KDMUd79gRf6v/jd3eb4vqKjXMqUss+/NLJ/4EzveVviJWBcMDnKAe9gHKfsA8cGzwguJU7nXbVXGA=;5:p8WfJmQ3joonea1lAwFTik91onOaRcfvtuIN1mHZR1GfbAHn8xZi7tKdg88BR1J0neFXR3H4g/qrLXy/RohXBUdbfM4quRWZRuAo+hU/C2x5/8vPGlqvWTalvV+FZ8tvvQzvR7nhclzRyWXal9DAgw==;24:mRxyJTrnPHZX2kH2MeifoMDZKwtaPFpdEcjg3TvsR2rVPGgoF/7yXexBDuTylbACH/0hkwEK1AhCSk9/NVqhONITFfCCqUXERzjh1agYwmw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1386;7:FKnabq7/Psu2wDMUGVuza2YFyxt+TUgW41Mokfi/0Npfl/J/Kg8gnoIWSVkJmyb+rS9dCnDbNgpUG2Bx1OPo4rOK5zfeB4cYGsI2mXTnaiTpiQ6sU6riw4EZM9649CxpXGt23NxWjmj31cZ8l+RKFmz6nyVbN2tbNTN/cCg5YJOUYXoV7L7+YoAmAkp2Axb3g5jIGzzrvk1wHMB5QBnXX2gHgYF9VttWW9NlhZaj2FVXzFWDeH9zyrTlzvpWHE8yrSdjr3Xyk7EBeXlqY5AnXgC8Rm9SE+iIhXTQyxiD1GJThC1ZsaTLl71qtiuZGmBlCO2gKhBqOecUQ7+UjQACIBXe9yqraxQeFAFXHwmSLXI=;20:wLxRty0aWgG1Y62pzgvSPXycrU6o11/fR3KBaFd56v6YoKIflmcfVbq5eQRK4kISHJswzhCHHx46tVqByOhbM5xvFtFaAQPHvHuzvOgd6g8e8bGz+xUozy4PtnNRtEZFl5N5U0Q9CcZxGECPbCLJ5KqIpw318tnRt1hGJNY/nkHfu6tA5qugvbmiWy7t5+tHG92QUYp75bCj02wA8YaRh9LlwaFOE8aSaRBhzFFMufJSpacP2RWjK3STmJR8/hlr X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2016 14:44:51.9624 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1386 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Call the struct simply smca_bank, it's instance ID can be simply ->id. > Makes the code much more readable. > > Signed-off-by: Borislav Petkov Looks good to me. Please add: Tested-by: Yazen Ghannam Ditto for the others. Thanks, Yazen