From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbcKHBiv (ORCPT ); Mon, 7 Nov 2016 20:38:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:48094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbcKHBis (ORCPT ); Mon, 7 Nov 2016 20:38:48 -0500 Date: Mon, 07 Nov 2016 20:38:46 -0500 (EST) Message-Id: <20161107.203846.734910693756417486.davem@davemloft.net> To: rafalo@cadence.com Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3] cadence: Add LSO support. From: David Miller In-Reply-To: <1478259618-23474-1-git-send-email-rafalo@cadence.com> References: <1477397130-24250-1-git-send-email-rafalo@cadence.com> <1478259618-23474-1-git-send-email-rafalo@cadence.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Nov 2016 16:39:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafal Ozieblo Date: Fri, 4 Nov 2016 11:40:18 +0000 > + if (IPPROTO_UDP == (((struct iphdr *)skb_network_header(skb))->protocol)) This is simply "ip_hdr(skb)->protocol", please use it everywhere you have this ugly cast thing in this change. Thanks.