From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules Date: Mon, 7 Nov 2016 09:29:20 +0800 Message-ID: <20161107012920.GA10559@b29397-desktop> References: <20161018015636.11701-1-stephen.boyd@linaro.org> <20161018015636.11701-3-stephen.boyd@linaro.org> <147733850401.29612.2343965740004706258@sboyd-linaro> <20161025011632.GA23876@b29397-desktop> <147829269430.21688.2345895151880009021@sboyd-linaro> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <147829269430.21688.2345895151880009021@sboyd-linaro> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Boyd , Greg KH Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Chen-Yu Tsai , Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb , linux-kernel , Bjorn Andersson , devicetree , Peter Chen , Andy Gross , linux-arm-kernel List-Id: linux-arm-msm@vger.kernel.org On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-24 18:16:32) > > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: > > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05) > > > > Hi, > > > > > > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd wrote: > > > > > The ULPI bus can be built as a module, and it will soon be > > > > > calling these functions when it supports probing devices from DT. > > > > > Export them so they can be used by the ULPI module. > > > > > > > > > > Acked-by: Rob Herring > > > > > Cc: > > > > > Signed-off-by: Stephen Boyd > > > > > --- > > > > > drivers/of/device.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > > > > index 8a22a253a830..6719ab35b62e 100644 > > > > > --- a/drivers/of/device.c > > > > > +++ b/drivers/of/device.c > > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len) > > > > > > > > > > return tsize; > > > > > } > > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias); > > > > > > > > > > int of_device_request_module(struct device *dev) > > > > > { > > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct kobj_uevent_env *env) > > > > > } > > > > > mutex_unlock(&of_mutex); > > > > > } > > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias); > > > > > > > > This is trailing the wrong function. > > > > > > > > > > Good catch. Must have been some bad rebase. > > > > > > Peter, can you fix it while applying or should I resend this patch? > > > > > > > But, this is device tree patch. I can only get chipidea part and other > > USB patches if Greg agrees. > > > > Were you expecting Rob to take the drivers/of/* patches? Sorry I thought > Rob acked them so they could go through usb with the other changes. I am just worried about possible merge error when linus pulls both OF and USB tree. Greg, is it ok the OF patches through USB tree with OF maintainer's ack? -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751573AbcKGBqT (ORCPT ); Sun, 6 Nov 2016 20:46:19 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34344 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbcKGBqQ (ORCPT ); Sun, 6 Nov 2016 20:46:16 -0500 Date: Mon, 7 Nov 2016 09:29:20 +0800 From: Peter Chen To: Stephen Boyd , Greg KH Cc: robh@kernel.org, Chen-Yu Tsai , Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-usb , linux-kernel , Bjorn Andersson , devicetree , Peter Chen , Andy Gross , linux-arm-kernel Subject: Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules Message-ID: <20161107012920.GA10559@b29397-desktop> References: <20161018015636.11701-1-stephen.boyd@linaro.org> <20161018015636.11701-3-stephen.boyd@linaro.org> <147733850401.29612.2343965740004706258@sboyd-linaro> <20161025011632.GA23876@b29397-desktop> <147829269430.21688.2345895151880009021@sboyd-linaro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147829269430.21688.2345895151880009021@sboyd-linaro> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-24 18:16:32) > > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: > > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05) > > > > Hi, > > > > > > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd wrote: > > > > > The ULPI bus can be built as a module, and it will soon be > > > > > calling these functions when it supports probing devices from DT. > > > > > Export them so they can be used by the ULPI module. > > > > > > > > > > Acked-by: Rob Herring > > > > > Cc: > > > > > Signed-off-by: Stephen Boyd > > > > > --- > > > > > drivers/of/device.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > > > > index 8a22a253a830..6719ab35b62e 100644 > > > > > --- a/drivers/of/device.c > > > > > +++ b/drivers/of/device.c > > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len) > > > > > > > > > > return tsize; > > > > > } > > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias); > > > > > > > > > > int of_device_request_module(struct device *dev) > > > > > { > > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct kobj_uevent_env *env) > > > > > } > > > > > mutex_unlock(&of_mutex); > > > > > } > > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias); > > > > > > > > This is trailing the wrong function. > > > > > > > > > > Good catch. Must have been some bad rebase. > > > > > > Peter, can you fix it while applying or should I resend this patch? > > > > > > > But, this is device tree patch. I can only get chipidea part and other > > USB patches if Greg agrees. > > > > Were you expecting Rob to take the drivers/of/* patches? Sorry I thought > Rob acked them so they could go through usb with the other changes. I am just worried about possible merge error when linus pulls both OF and USB tree. Greg, is it ok the OF patches through USB tree with OF maintainer's ack? -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: hzpeterchen@gmail.com (Peter Chen) Date: Mon, 7 Nov 2016 09:29:20 +0800 Subject: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules In-Reply-To: <147829269430.21688.2345895151880009021@sboyd-linaro> References: <20161018015636.11701-1-stephen.boyd@linaro.org> <20161018015636.11701-3-stephen.boyd@linaro.org> <147733850401.29612.2343965740004706258@sboyd-linaro> <20161025011632.GA23876@b29397-desktop> <147829269430.21688.2345895151880009021@sboyd-linaro> Message-ID: <20161107012920.GA10559@b29397-desktop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-24 18:16:32) > > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: > > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05) > > > > Hi, > > > > > > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd wrote: > > > > > The ULPI bus can be built as a module, and it will soon be > > > > > calling these functions when it supports probing devices from DT. > > > > > Export them so they can be used by the ULPI module. > > > > > > > > > > Acked-by: Rob Herring > > > > > Cc: > > > > > Signed-off-by: Stephen Boyd > > > > > --- > > > > > drivers/of/device.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c > > > > > index 8a22a253a830..6719ab35b62e 100644 > > > > > --- a/drivers/of/device.c > > > > > +++ b/drivers/of/device.c > > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len) > > > > > > > > > > return tsize; > > > > > } > > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias); > > > > > > > > > > int of_device_request_module(struct device *dev) > > > > > { > > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct kobj_uevent_env *env) > > > > > } > > > > > mutex_unlock(&of_mutex); > > > > > } > > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias); > > > > > > > > This is trailing the wrong function. > > > > > > > > > > Good catch. Must have been some bad rebase. > > > > > > Peter, can you fix it while applying or should I resend this patch? > > > > > > > But, this is device tree patch. I can only get chipidea part and other > > USB patches if Greg agrees. > > > > Were you expecting Rob to take the drivers/of/* patches? Sorry I thought > Rob acked them so they could go through usb with the other changes. I am just worried about possible merge error when linus pulls both OF and USB tree. Greg, is it ok the OF patches through USB tree with OF maintainer's ack? -- Best Regards, Peter Chen