From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752703AbcKGMbh (ORCPT ); Mon, 7 Nov 2016 07:31:37 -0500 Received: from mail.skyhub.de ([78.46.96.112]:47651 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbcKGMbf (ORCPT ); Mon, 7 Nov 2016 07:31:35 -0500 Date: Mon, 7 Nov 2016 13:31:29 +0100 From: Borislav Petkov To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Tony Luck , linux-edac@vger.kernel.org, x86@kernel.org, Thomas Gleixner Subject: Re: [PATCH 20/25] x86/mcheck: Be prepared for a rollback back to the ONLINE state Message-ID: <20161107123129.4tokksued24maiab@pd.tnic> References: <20161103145021.28528-1-bigeasy@linutronix.de> <20161103145021.28528-21-bigeasy@linutronix.de> <20161107103219.sm4otwhwptzckvzh@pd.tnic> <20161107104054.7lcuca5sjxvgxhzk@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161107104054.7lcuca5sjxvgxhzk@linutronix.de> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2016 at 11:40:55AM +0100, Sebastian Andrzej Siewior wrote: > On 2016-11-07 11:32:19 [+0100], Borislav Petkov wrote: > > On Thu, Nov 03, 2016 at 03:50:16PM +0100, Sebastian Andrzej Siewior wrote: > > > If we try a CPU down and fail in the middle then we roll back to the > > > online state. This means we would perform CPU_ONLINE() > > > without invoking CPU_DEAD() for the cleanup of what was allocated in > > > > Are CPU_ONLINE() and CPU_DEAD() functions? Those are the states, right? > > those are states. I meant here the driver specific function invoked in > those states. Yeah, so say that please - slapping "()" after the state name doesn't make it clear. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.