From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54785 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbcKIGLf (ORCPT ); Wed, 9 Nov 2016 01:11:35 -0500 Date: Wed, 9 Nov 2016 07:11:45 +0100 From: Greg KH To: Stefan Agner Cc: stable@vger.kernel.org, Wolfram Sang , stable@kernel.org Subject: Re: [PATCH] i2c: imx: defer probe if bus recovery GPIOs are not ready Message-ID: <20161109061145.GB2739@kroah.com> References: <20161109003239.16940-1-stefan@agner.ch> <847750bba7bed752906f75f5df3f8344@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <847750bba7bed752906f75f5df3f8344@agner.ch> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Nov 08, 2016 at 04:34:50PM -0800, Stefan Agner wrote: > On 2016-11-08 16:32, Stefan Agner wrote: > > commit 533169d164c6b4c8571d0d48779f6ff6be593d72 upstream. > > > > Some SoC might load the GPIO driver after the I2C driver and > > using the I2C bus recovery mechanism via GPIOs. In this case > > it is crucial to defer probing if the GPIO request functions > > do so, otherwise the I2C driver gets loaded without recovery > > mechanisms enabled. > > > > Signed-off-by: Stefan Agner > > Acked-by: Uwe Kleine-K�nig > > Acked-by: Li Yang > > Signed-off-by: Wolfram Sang > > Cc: stable@kernel.org > > I forgot to mention, this should be applied to 4.4 only. Did you build the code there? > Later versions made the return value void, and it would require a larger > rework. I am mainly concerned about LTS... I don't see this working for either 4.4 or 4.8-stable right now, do you? confused, greg k-h