All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rvatsavayi@caviumnetworks.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@caviumnetworks.com,
	derek.chickles@caviumnetworks.com,
	satananda.burla@caviumnetworks.com,
	felix.manlunas@caviumnetworks.com
Subject: Re: [PATCH net-next V5 3/9] liquidio CN23XX: Mailbox support
Date: Thu, 10 Nov 2016 12:19:10 -0500 (EST)	[thread overview]
Message-ID: <20161110.121910.154188943242358141.davem@davemloft.net> (raw)
In-Reply-To: <1478733232-15739-4-git-send-email-rvatsavayi@caviumnetworks.com>

From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Date: Wed, 9 Nov 2016 15:13:46 -0800

> +		dev_info(&oct->pci_dev->dev,
> +			 "PF changed VF's MAC address to %02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx\n",
> +			 mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]);

We have a standard mechanism to print network addresses, including
MAC ones, via the %pXXX format specifier.  In this case you should
use "%pM" or "%pm" depending upon whether you want the address printed
with colon separators or not.

  reply	other threads:[~2016-11-10 17:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 23:13 [PATCH net-next V5 0/9] liquidio CN23XX VF support Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 1/9] liquidio CN23XX: HW config for " Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 2/9] liquidio CN23XX: sysfs VF config support Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 3/9] liquidio CN23XX: Mailbox support Raghu Vatsavayi
2016-11-10 17:19   ` David Miller [this message]
2016-11-10 17:44     ` Vatsavayi, Raghu
2016-11-10 17:53       ` David Miller
2016-11-09 23:13 ` [PATCH net-next V5 4/9] liquidio CN23XX: mailbox interrupt processing Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 5/9] liquidio CN23XX: VF related operations Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 6/9] liquidio CN23XX: device states Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 7/9] liquidio CN23XX: code cleanup Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 8/9] liquidio CN23XX: copyrights changes and alignment Raghu Vatsavayi
2016-11-09 23:13 ` [PATCH net-next V5 9/9] liquidio CN23XX: fix for new check patch errors Raghu Vatsavayi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161110.121910.154188943242358141.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=derek.chickles@caviumnetworks.com \
    --cc=felix.manlunas@caviumnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=raghu.vatsavayi@caviumnetworks.com \
    --cc=rvatsavayi@caviumnetworks.com \
    --cc=satananda.burla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.