From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933202AbcKJN1g (ORCPT ); Thu, 10 Nov 2016 08:27:36 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36731 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932295AbcKJN1e (ORCPT ); Thu, 10 Nov 2016 08:27:34 -0500 Date: Thu, 10 Nov 2016 13:30:19 +0000 From: Lee Jones To: Charles Keepax Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 1/2] mfd: arizona: Use irq_find_mapping when appropriate Message-ID: <20161110133019.GS13127@dell> References: <1477650774-22239-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1477650774-22239-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Oct 2016, Charles Keepax wrote: > No need to use irq_create_mapping (although there is no issue with > doing so) when we are only looking up an existing mapping. Just to > streamline things a little and make the code a little more clear > change some calls from irq_create_mapping to irq_find_mapping. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-irq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c > index 5e18d3c..2e01975 100644 > --- a/drivers/mfd/arizona-irq.c > +++ b/drivers/mfd/arizona-irq.c > @@ -398,10 +398,10 @@ int arizona_irq_init(struct arizona *arizona) > err_boot_done: > free_irq(arizona->irq, arizona); > err_main_irq: > - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 1), > + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 1), > arizona->irq_chip); > err_aod: > - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 0), > + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 0), > arizona->aod_irq_chip); > err: > return ret; > @@ -413,9 +413,9 @@ int arizona_irq_exit(struct arizona *arizona) > free_irq(arizona_map_irq(arizona, ARIZONA_IRQ_CTRLIF_ERR), > arizona); > free_irq(arizona_map_irq(arizona, ARIZONA_IRQ_BOOT_DONE), arizona); > - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 1), > + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 1), > arizona->irq_chip); > - regmap_del_irq_chip(irq_create_mapping(arizona->virq, 0), > + regmap_del_irq_chip(irq_find_mapping(arizona->virq, 0), > arizona->aod_irq_chip); > free_irq(arizona->irq, arizona); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog