From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: PM regression with LED changes in next-20161109 Date: Thu, 10 Nov 2016 21:29:10 +0100 Message-ID: <20161110202910.GE28832@amd> References: <20161109192301.GS26979@atomide.com> <28234714-3994-6747-9cf8-1ff0b3257f7a@gmail.com> <5bd5333e-0dbb-6333-0a48-ca4d3a990f9c@samsung.com> <20161110162925.GA28832@amd> <20161110175537.GF27724@atomide.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vv4Sf/kQfcwinyKX" Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33746 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965581AbcKJU3O (ORCPT ); Thu, 10 Nov 2016 15:29:14 -0500 Content-Disposition: inline In-Reply-To: <20161110175537.GF27724@atomide.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Tony Lindgren Cc: Jacek Anaszewski , Hans de Goede , Jacek Anaszewski , linux-leds@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Darren Hart --vv4Sf/kQfcwinyKX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2016-11-10 10:55:37, Tony Lindgren wrote: > * Pavel Machek [161110 09:29]: > > Hi! > >=20 > > > >>>Looks like commit 883d32ce3385 ("leds: core: Add support for poll(= )ing > > > >>>the sysfs brightness attr for changes.") breaks runtime PM for me. > > > >>> > > > >>>On my omap dm3730 based test system, idle power consumption is ove= r 70 > > > >>>times higher now with this patch! It goes from about 6mW for the c= ore > > > >>>system to over 440mW during idle meaning there's some busy timer n= ow > > > >>>active. > > > >>> > > > >>>Reverting this patch fixes the issue. Any ideas? > >=20 > > Are you using any LED that toggles with high frequency? Like perhaps > > LED that is lit when CPU is active? >=20 > Yeah one of them seems to have cpu0 as the default trigger. Aha. Its quite obvious we don't want to notify sysfs each time that one is toggled, right? IMO brightness should display max brightness for the trigger, as Hans suggested, anything else is madness for trigger such as cpu activity. Thanks and best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vv4Sf/kQfcwinyKX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlgk2JYACgkQMOfwapXb+vIqvACgio501ouK+/EMLvFEPdOiKMuK w2YAoINJ1X7Ehl/PKJDbBGVjpfYtg0Fr =Vr2J -----END PGP SIGNATURE----- --vv4Sf/kQfcwinyKX-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Thu, 10 Nov 2016 21:29:10 +0100 Subject: PM regression with LED changes in next-20161109 In-Reply-To: <20161110175537.GF27724@atomide.com> References: <20161109192301.GS26979@atomide.com> <28234714-3994-6747-9cf8-1ff0b3257f7a@gmail.com> <5bd5333e-0dbb-6333-0a48-ca4d3a990f9c@samsung.com> <20161110162925.GA28832@amd> <20161110175537.GF27724@atomide.com> Message-ID: <20161110202910.GE28832@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu 2016-11-10 10:55:37, Tony Lindgren wrote: > * Pavel Machek [161110 09:29]: > > Hi! > > > > > >>>Looks like commit 883d32ce3385 ("leds: core: Add support for poll()ing > > > >>>the sysfs brightness attr for changes.") breaks runtime PM for me. > > > >>> > > > >>>On my omap dm3730 based test system, idle power consumption is over 70 > > > >>>times higher now with this patch! It goes from about 6mW for the core > > > >>>system to over 440mW during idle meaning there's some busy timer now > > > >>>active. > > > >>> > > > >>>Reverting this patch fixes the issue. Any ideas? > > > > Are you using any LED that toggles with high frequency? Like perhaps > > LED that is lit when CPU is active? > > Yeah one of them seems to have cpu0 as the default trigger. Aha. Its quite obvious we don't want to notify sysfs each time that one is toggled, right? IMO brightness should display max brightness for the trigger, as Hans suggested, anything else is madness for trigger such as cpu activity. Thanks and best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: