From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com Date: Thu, 10 Nov 2016 22:33:34 +0100 From: Peter Zijlstra Message-ID: <20161110213334.GZ3117@twins.programming.kicks-ass.net> References: <1478809488-18303-1-git-send-email-elena.reshetova@intel.com> <1478809488-18303-13-git-send-email-elena.reshetova@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478809488-18303-13-git-send-email-elena.reshetova@intel.com> Subject: [kernel-hardening] Re: [RFC v4 PATCH 12/13] x86: implementation for HARDENED_ATOMIC To: Elena Reshetova Cc: kernel-hardening@lists.openwall.com, keescook@chromium.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, h.peter.anvin@intel.com, will.deacon@arm.com, Hans Liljestrand , David Windsor List-ID: On Thu, Nov 10, 2016 at 10:24:47PM +0200, Elena Reshetova wrote: > +static __always_inline int atomic_cmpxchg_wrap(atomic_wrap_t *v, int old, int new) > +{ > + return cmpxchg(&v->counter, old, new); > +} WTH does that even mean, a wrap for a cmpxchg. I seriously detest this interface