From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 24D1F95D for ; Fri, 11 Nov 2016 10:04:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5F0D0279 for ; Fri, 11 Nov 2016 10:04:32 +0000 (UTC) Date: Fri, 11 Nov 2016 07:34:47 -0200 From: Mauro Carvalho Chehab To: Jani Nikula Message-ID: <20161111073447.4dd590b0.m.chehab@samsung.com> In-Reply-To: <87shr0g90r.fsf@intel.com> References: <20161107075524.49d83697@vento.lan> <20161107170133.4jdeuqydthbbchaq@x> <8737j0hpi0.fsf@intel.com> <87shr0g90r.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Markus Heiser , ksummit-discuss@lists.linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [Ksummit-discuss] Including images on Sphinx documents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Em Wed, 09 Nov 2016 13:58:12 +0200 Jani Nikula escreveu: > On Wed, 09 Nov 2016, Markus Heiser wrote: > > Am 09.11.2016 um 12:16 schrieb Jani Nikula : > >>> So I vote for : > >>> > >>>> 1) copy (or symlink) all rst files to Documentation/output (or to the > >>>> build dir specified via O= directive) and generate the *.pdf there, > >>>> and produce those converted images via Makefile.; > >> > >> We're supposed to solve problems, not create new ones. > > > > ... new ones? ... > > Handle in-tree builds without copying. > > Make dependency analysis with source rst and "intermediate" rst work. > > Make sure your copying gets the timestamps right. > > Make Sphinx dependency analysis look at the right copies depending on > in-tree vs. out-of-tree. Generally make sure it doesn't confuse Sphinx's > own dependency analysis. I agree with Jani here: copy the files will make Sphinx recompile the entire documentation every time, with is bad. Ok, Some Makefile logic could be added to copy only on changes, but that will increase the Makefile complexity. So, I prefer not using copy. As I said before, a Sphinx extension that would make transparent for PDF document generation when a non-PDF image is included, doing whatever conversion needed, seems to be the right fix here, but someone would need to step up and write such extension. -- Cheers, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966026AbcKKJfC (ORCPT ); Fri, 11 Nov 2016 04:35:02 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:45657 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965305AbcKKJe7 (ORCPT ); Fri, 11 Nov 2016 04:34:59 -0500 Date: Fri, 11 Nov 2016 07:34:47 -0200 From: Mauro Carvalho Chehab To: Jani Nikula Cc: Markus Heiser , Josh Triplett , Mauro Carvalho Chehab , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, ksummit-discuss@lists.linuxfoundation.org, linux-doc@vger.kernel.org Subject: Re: [Ksummit-discuss] Including images on Sphinx documents Message-ID: <20161111073447.4dd590b0.m.chehab@samsung.com> In-Reply-To: <87shr0g90r.fsf@intel.com> References: <20161107075524.49d83697@vento.lan> <20161107170133.4jdeuqydthbbchaq@x> <8737j0hpi0.fsf@intel.com> <87shr0g90r.fsf@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 09 Nov 2016 13:58:12 +0200 Jani Nikula escreveu: > On Wed, 09 Nov 2016, Markus Heiser wrote: > > Am 09.11.2016 um 12:16 schrieb Jani Nikula : > >>> So I vote for : > >>> > >>>> 1) copy (or symlink) all rst files to Documentation/output (or to the > >>>> build dir specified via O= directive) and generate the *.pdf there, > >>>> and produce those converted images via Makefile.; > >> > >> We're supposed to solve problems, not create new ones. > > > > ... new ones? ... > > Handle in-tree builds without copying. > > Make dependency analysis with source rst and "intermediate" rst work. > > Make sure your copying gets the timestamps right. > > Make Sphinx dependency analysis look at the right copies depending on > in-tree vs. out-of-tree. Generally make sure it doesn't confuse Sphinx's > own dependency analysis. I agree with Jani here: copy the files will make Sphinx recompile the entire documentation every time, with is bad. Ok, Some Makefile logic could be added to copy only on changes, but that will increase the Makefile complexity. So, I prefer not using copy. As I said before, a Sphinx extension that would make transparent for PDF document generation when a non-PDF image is included, doing whatever conversion needed, seems to be the right fix here, but someone would need to step up and write such extension. -- Cheers, Mauro