From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1c5FSu-0005UJ-S2
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 12:18:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1c5FSo-0002hi-TT
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 12:18:12 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37473)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <cota@braap.org>) id 1c5FSo-0002hG-NW
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 12:18:06 -0500
Date: Fri, 11 Nov 2016 12:18:04 -0500
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20161111171804.GA17480@flamenco>
References: <1468881010-27229-1-git-send-email-mst@redhat.com>
	<20160719014441-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160719014441-mutt-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL 22/55] q35: ioapic: add support for emulated
 IOAPIC IR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alex =?utf-8?B?QmVubu+/vWU=?= <alex.bennee@linaro.org>

On Tue, Jul 19, 2016 at 01:44:41 +0300, Michael S. Tsirkin wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> This patch translates all IOAPIC interrupts into MSI ones. One pseudo
> ioapic address space is added to transfer the MSI message. By default,
> it will be system memory address space. When IR is enabled, it will be
> IOMMU address space.
> 
> Currently, only emulated IOAPIC is supported.
> 
> Idea suggested by Jan Kiszka and Rita Sinha in the following patch:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01933.html
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  include/hw/i386/apic-msidef.h     |  1 +
>  include/hw/i386/ioapic_internal.h |  1 +
>  include/hw/i386/pc.h              |  4 ++++
>  hw/i386/intel_iommu.c             |  6 +++++-
>  hw/i386/pc.c                      |  3 +++
>  hw/intc/ioapic.c                  | 28 ++++++++++++++++++++++++----
>  6 files changed, 38 insertions(+), 5 deletions(-)

This commit (which sits between 2.6 and 2.7) doesn't let me boot a
buildroot-generated x86_64 image when QEMU is configured with
--with-coroutine=gthread (it deadlocks on the BQL shortly after
the framebuffer comes up.)

Is this something we should worry about? I see in the configure
script that --with-coroutine=gthread "is not functional enough to run
QEMU proper". My goal is to use thread sanitizer (tsan) to test
mttcg for x86-64. Unfortunately, tsan blows with ucontext coroutines.

Thanks,

		Emilio