From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andreas Noever
<andreas.noever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v4 2/4] efi: Allow bitness-agnostic protocol calls
Date: Sat, 12 Nov 2016 09:02:55 +0000 [thread overview]
Message-ID: <20161112090255.GH8845@codeblueprint.co.uk> (raw)
In-Reply-To: <b6591dbe76700984afd4c881408aadb7b10587ba.1478506920.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
On Mon, 07 Nov, at 11:09:00AM, Lukas Wunner wrote:
> We already have a macro to invoke boot services which on x86 adapts
> automatically to the bitness of the EFI firmware: efi_call_early().
>
> The macro allows sharing of functions across arches and bitness variants
> as long as those functions only call boot services. However in practice
> functions in the EFI stub contain a mix of boot services calls and
> protocol calls.
>
> Add an efi_call_proto() macro for bitness-agnostic protocol calls to
> allow sharing more code across arches as well as deduplicating 32 bit
> and 64 bit code paths.
>
> On x86, implement it using a new efi_table_attr() macro for bitness-
> agnostic table lookups. Refactor efi_call_early() to make use of the
> same macro. (The resulting object code remains identical.)
>
> Cc: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
> Cc: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Signed-off-by: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
> ---
> arch/arm/include/asm/efi.h | 3 +++
> arch/arm64/include/asm/efi.h | 3 +++
> arch/x86/include/asm/efi.h | 16 +++++++++++-----
> 3 files changed, 17 insertions(+), 5 deletions(-)
Neat!
next prev parent reply other threads:[~2016-11-12 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 10:09 [PATCH v4 0/4] Apple device properties Lukas Wunner
[not found] ` <cover.1478506920.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-11-07 10:09 ` [PATCH v4 3/4] x86/efi: Retrieve and assign " Lukas Wunner
2016-11-07 10:09 ` [PATCH v4 1/4] efi: Add device path parser Lukas Wunner
2016-11-07 10:09 ` [PATCH v4 4/4] thunderbolt: Use Device ROM retrieved from EFI Lukas Wunner
2016-11-07 10:09 ` [PATCH v4 2/4] efi: Allow bitness-agnostic protocol calls Lukas Wunner
[not found] ` <b6591dbe76700984afd4c881408aadb7b10587ba.1478506920.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-11-12 9:02 ` Matt Fleming [this message]
2016-11-12 10:10 ` [PATCH v4 0/4] Apple device properties Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161112090255.GH8845@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=andreas.noever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.