All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH RFC 2/4] xfs: logically separate iomap range from allocation range
Date: Tue, 15 Nov 2016 13:11:08 -0500	[thread overview]
Message-ID: <20161115181108.GD65218@bfoster.bfoster> (raw)
In-Reply-To: <20161115141804.GB18630@infradead.org>

On Tue, Nov 15, 2016 at 06:18:04AM -0800, Christoph Hellwig wrote:
> On Tue, Nov 08, 2016 at 03:27:34PM -0500, Brian Foster wrote:
> > The xfs_file_iomap_begin_delay() function currently converts the bmbt
> > record output from the xfs_bmapi_reserve_delalloc() call to the iomap
> > mapping for the higher level iomap code. In preparation to reuse
> > xfs_file_iomap_begin_delay() for data fork and COW fork allocation,
> > logically separate the iomap mapping provided to the caller from the
> > bmbt record returned by xfs_bmapi_reserve_delalloc().
> > 
> > This is necessary because while COW reservation involves delalloc
> > allocation to the COW fork, the mapping returned to the caller must
> > still refer to the shared blocks from the data fork. Note that this
> > patch does not change behavior in any way.
> 
> On it's own this patch looks highly confusing.  I'll keep reading
> the rest of the series if it makes more sense with that, but in doubt
> it probably should be merged into whatever patches it helps with.

Heh, Ok. I'll revisit this when the rest of the code is more fleshed
out.

Brian

  reply	other threads:[~2016-11-15 18:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 20:27 [PATCH RFC 0/4] xfs: basic cow fork speculative preallocation Brian Foster
2016-11-08 20:27 ` [PATCH RFC 1/4] xfs: clean up cow fork reservation and tag inodes correctly Brian Foster
2016-11-15 14:16   ` Christoph Hellwig
2016-11-15 18:11     ` Brian Foster
2016-11-18  8:11       ` Christoph Hellwig
2016-11-18 15:10         ` Brian Foster
2016-11-08 20:27 ` [PATCH RFC 2/4] xfs: logically separate iomap range from allocation range Brian Foster
2016-11-15 14:18   ` Christoph Hellwig
2016-11-15 18:11     ` Brian Foster [this message]
2016-11-08 20:27 ` [PATCH RFC 3/4] xfs: reuse xfs_file_iomap_begin_delay() for cow fork delalloc Brian Foster
2016-11-15 14:28   ` Christoph Hellwig
2016-11-15 18:11     ` Brian Foster
2016-11-18  8:13       ` Christoph Hellwig
2016-11-18 15:11         ` Brian Foster
2016-11-08 20:27 ` [PATCH RFC 4/4] xfs: implement basic COW fork speculative preallocation Brian Foster
2016-11-08 20:48 ` [PATCH RFC 0/4] xfs: basic cow " Darrick J. Wong
2016-11-08 22:39   ` Brian Foster
2016-11-08 23:34     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161115181108.GD65218@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.