From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48196)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c6zCI-0000Oq-EW
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 07:20:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1c6zCH-0001hJ-JN
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 07:20:14 -0500
Date: Wed, 16 Nov 2016 13:20:01 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20161116122001.GA5407@noname.str.redhat.com>
References: <20160926080838.6992.95614.stgit@PASHA-ISP>
	<20160926092346.GE6093@noname.str.redhat.com>
	<002001d217db$845fc030$8d1f4090$@ru>
	<20160926131721.GH6093@noname.str.redhat.com>
	<001101d218c8$67aa1010$36fe3030$@ru>
	<20160928083620.GD5236@noname.redhat.com>
	<001501d2196b$496b4e90$dc41ebb0$@ru>
	<20160928094313.GI5236@noname.redhat.com>
	<000001d21986$b68cd280$23a67780$@ru>
	<001d01d23fee$b962ec40$2c28c4c0$@ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001d01d23fee$b962ec40$2c28c4c0$@ru>
Subject: Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for
 filters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>
Cc: 'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>, qemu-devel@nongnu.org, peter.maydell@linaro.org, quintela@redhat.com, jasowang@redhat.com, mst@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org

Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben:
> > From: Pavel Dovgalyuk [mailto:dovgaluk@ispras.ru]
> > > From: Kevin Wolf [mailto:kwolf@redhat.com]
> > > My command line was assuming a raw image. It looks like you're using a
> > > qcow (hopefully qcow2?) image. If so, then you need to include the qcow2
> > > driver:
> > >
> > > -drive driver=blkreplay,if=none,image.driver=qcow2,\
> > > image.file.driver=file,image.file.filename=testdisk.qcow,id=img-blkreplay
> > 
> > This doesn't work for some reason. Replay just hangs at some moment.
> > 
> > Maybe there exists some internal difference between command line with one or two -drive
> > options?
> 
> I've investigated this issue.
> This command line works ok:
>  -drive driver=blkreplay,if=none,image.driver=file,image.filename=testdisk.qcow,id=img-blkreplay 
>  -device ide-hd,drive=img-blkreplay
> 
> And this does not:
>  -drive
> driver=blkreplay,if=none,image.driver=qcow2,image.file.driver=file,image.file.filename=testdisk.qcow
> ,id=img-blkreplay
>  -device ide-hd,drive=img-blkreplay
> 
> QEMU hangs at some moment of replay.
> 
> I found that some dma requests do not pass through the blkreplay driver
> due to the following line in block-backend.c:
>     return bdrv_co_preadv(blk->root, offset, bytes, qiov, flags);
> 
> This line passes read request directly to qcow driver and blkreplay cannot
> process it to make deterministic.

How does that bypass blkreplay? blk->root is supposed to be the blkreply
node, do you see something different? If it were the qcow2 node, then I
would expect that no requests at all go through the blkreplay layer.

Kevin