From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39424)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1c75Tc-0005IW-Ps
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 14:02:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1c75Tb-0006Zf-Oq
	for qemu-devel@nongnu.org; Wed, 16 Nov 2016 14:02:32 -0500
Date: Wed, 16 Nov 2016 17:02:22 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20161116190222.GS5057@thinpad.lan.raisama.net>
References: <1479320499-29818-1-git-send-email-ehabkost@redhat.com>
	<b5f6826a-0662-9d7d-7321-20d425fb651c@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b5f6826a-0662-9d7d-7321-20d425fb651c@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.9] qmp: Report QOM type name on
 query-cpu-definitions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, David Gibson <dgibson@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrange" <berrange@redhat.com>, Jiri Denemark <jdenemar@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>, Alexander Graf <agraf@suse.de>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, libvir-list@redhat.com

On Wed, Nov 16, 2016 at 12:47:14PM -0600, Eric Blake wrote:
> On 11/16/2016 12:21 PM, Eduardo Habkost wrote:
> > The new typename attribute on query-cpu-definitions will be used
> > to help management software use device-list-properties to check
> > which properties can be set using -cpu or -global for the CPU
> > model.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  qapi-schema.json            | 4 +++-
> >  target-arm/helper.c         | 1 +
> >  target-i386/cpu.c           | 1 +
> >  target-ppc/translate_init.c | 1 +
> >  target-s390x/cpu_models.c   | 1 +
> >  5 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index b0b4bf6..9a3bdd4 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -3216,6 +3216,8 @@
> >  # @unavailable-features: #optional List of properties that prevent
> >  #                        the CPU model from running in the current
> >  #                        host. (since 2.8)
> > +# @typename: Type name that can be used as argument to @device-list-properties,
> > +#            to introspect properties configurable using -cpu or -global.
> 
> Missing a '(since 2.9)' designation.

Oops. I will add it the next version. Thanks!

> 
> >  #
> >  # @unavailable-features is a list of QOM property names that
> >  # represent CPU model attributes that prevent the CPU from running.
> > @@ -3237,7 +3239,7 @@
> >  ##
> >  { 'struct': 'CpuDefinitionInfo',
> >    'data': { 'name': 'str', '*migration-safe': 'bool', 'static': 'bool',
> > -            '*unavailable-features': [ 'str' ] } }
> > +            '*unavailable-features': [ 'str' ], 'typename': 'str' } }
> >  
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 

-- 
Eduardo