From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7E9I-0001XS-2u for qemu-devel@nongnu.org; Wed, 16 Nov 2016 23:18:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7E9G-0002TD-T2 for qemu-devel@nongnu.org; Wed, 16 Nov 2016 23:18:08 -0500 Date: Thu, 17 Nov 2016 15:12:23 +1100 From: David Gibson Message-ID: <20161117041223.GH18808@umbus.fritz.box> References: <1479326850-8369-1-git-send-email-joserz@linux.vnet.ibm.com> <1479326850-8369-3-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fd5uyaI9j6xoeUBo" Content-Disposition: inline In-Reply-To: <1479326850-8369-3-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 2/4] target-ppc: Implement bcdctsq. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --fd5uyaI9j6xoeUBo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 16, 2016 at 06:07:28PM -0200, Jose Ricardo Ziviani wrote: > bcdctsq.: Decimal convert to signed quadword. It is possible to > convert packed decimal values to signed quadwords. >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 39 +++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate/vmx-impl.inc.c | 7 +++++++ > 3 files changed, 47 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 87f533c..503f257 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -383,6 +383,7 @@ DEF_HELPER_3(bcdctn, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfz, i32, avr, avr, i32) > DEF_HELPER_3(bcdctz, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfsq, i32, avr, avr, i32) > +DEF_HELPER_3(bcdctsq, i32, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index db65a51..1025438 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2922,6 +2922,45 @@ uint32_t helper_bcdcfsq(ppc_avr_t *r, ppc_avr_t *b= , uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdctsq(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps) > +{ > + uint8_t i; > + int cr =3D 0; > + uint64_t hi =3D 0; > + int sgnb =3D bcd_get_sgn(b); > + int invalid =3D (sgnb =3D=3D 0); > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + > + ret.u64[LO_IDX] =3D bcd_get_digit(b, 31, &invalid); > + for (i =3D 30; i > 0; i--) { > + mulu64(&ret.u64[LO_IDX], &hi, > + ret.u64[LO_IDX], 10ULL); > + > + ret.u64[HI_IDX] =3D (ret.u64[HI_IDX]) ? ret.u64[HI_IDX] * 10 + h= i : hi; > + ret.u64[LO_IDX] +=3D bcd_get_digit(b, i, &invalid); Again, it might be simpler to use the int128 code we already have in qemu. > + if (unlikely(invalid)) { > + break; > + } > + } > + > + if (sgnb =3D=3D -1) { > + if (ret.s64[HI_IDX] > 0) { > + ret.s64[HI_IDX] =3D -ret.s64[HI_IDX]; > + } else { > + ret.s64[LO_IDX] =3D -ret.s64[LO_IDX]; > + } As on the other direction, I don't think this looks like a correct 128-bit negate. > + } > + > + cr =3D bcd_cmp_zero(b); > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 36141e5..1579b58 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -990,10 +990,14 @@ GEN_BCD2(bcdctn) > GEN_BCD2(bcdcfz) > GEN_BCD2(bcdctz) > GEN_BCD2(bcdcfsq) > +GEN_BCD2(bcdctsq) > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > switch (opc4(ctx->opcode)) { > + case 0: > + gen_bcdctsq(ctx); > + break; > case 2: > gen_bcdcfsq(ctx); > break; > @@ -1018,6 +1022,9 @@ static void gen_xpnd04_1(DisasContext *ctx) > static void gen_xpnd04_2(DisasContext *ctx) > { > switch (opc4(ctx->opcode)) { > + case 0: > + gen_bcdctsq(ctx); > + break; > case 2: > gen_bcdcfsq(ctx); > break; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fd5uyaI9j6xoeUBo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLS4kAAoJEGw4ysog2bOSh04P/152dHX4dVdePJbE+FQbmkuD mN3unO77OQDwySQVf6eQaVEglOEgA7Jm6dRD9hds3XOrJZHnfJzUHwLrm5qoRnj7 QVJtD2EzYIIxG9I3ddlizi5wn4nYy7C3fShgCb8up7ERm0YXy9LwFz3I8N1dGSuT EF54ODOUboRtbf+qofZe4P96ANNWrTKBGDOmxKbqqa/W3RPJg9BczL1vzd54BvBk RRhAotoc4yhSGIqRZFRc8zt8emp2jT5RLRMvRMZPqqTXgge5LSiRQVUZ52JapEIf 9pkfd9Il7uZfU1fPrHOQ4ZvlQ70E/EH4f0YWdXLgQ4BF9NcUwMfeFNODHzvLWG9O 14KJGZ4VMnAZ8lbMD41bFHB8/d1w390kium46lod0ppU4CkHSnb0xT3+awCZOkmt VcfpOm7PYhqDAatUcelKZcXWc7yCu9RIlFJQgInrNONCUBgGoWmRNuak4RBV/Wfl JCT4x8Lvrd3+WMyhg7+fyBfPjmmO5mtS97JDbyASOBEbC4rIKKNTvy1Zl+7YmHax cKeYoZW+JqvG5U5rxA37icQsJ3ADVZz+B4fMY2Owg7AYfPItPJlqtjNCNR9FMhVg pai8do7RYBYrOBNtXaKuBHP9qwnqNgTh0+/1b8q5OtG7pr3A0VUnr812tv25NRi2 bVz4K170tsLvXa4qq9vu =pIQk -----END PGP SIGNATURE----- --fd5uyaI9j6xoeUBo--