From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Thu, 17 Nov 2016 18:09:20 +0100
Subject: [U-Boot] [PATCH] spl: mmc: fix build without
 CONFIG_SPL_LIBCOMMON_SUPPORT
In-Reply-To: <88750dae-ca01-0492-cd1d-fa1d4bb3f8e7@samsung.com>
References: <CGME20161113214655epcas4p3a2ea71ae6e8470cac1996ee59d73563a@epcas4p3.samsung.com>
 <1479073579-30771-1-git-send-email-yann.morin.1998@free.fr>
 <88750dae-ca01-0492-cd1d-fa1d4bb3f8e7@samsung.com>
Message-ID: <20161117170920.GB3574@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jaehoon, All,

On 2016-11-17 17:09 +0900, Jaehoon Chung spake thusly:
> On 11/14/2016 06:46 AM, Yann E. MORIN wrote:
> > When CONFIG_SPL_LIBCOMMON_SUPPORT is disabled, the last case statement
> > is missing a proper statement, which makes the compiler whine.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> > ---
> >  common/spl/spl_mmc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> > index c674e61..cc81d19 100644
> > --- a/common/spl/spl_mmc.c
> > +++ b/common/spl/spl_mmc.c
> > @@ -343,6 +343,7 @@ static int spl_mmc_load_image(struct spl_image_info *spl_image,
> >  
> >  		break;
> >  	case MMCSD_MODE_UNDEFINED:
> > +		;
> >  #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
> >  	default:
> >  		puts("spl: mmc: wrong boot mode\n");
> 
> case MMCSD_MODE_UNDEFINED:
>  ...
> #ifdef CONFIG_....
> default:
> 	put()
> #endif
> 	break; 
> 
> 
> How about adding "break"?

>From what I understood, Tom Rini has another patch he preferred:
    https://patchwork.ozlabs.org/patch/694196/
in which he pointed to:
    https://patchwork.ozlabs.org/patch/689910/

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'