From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941849AbcKQSN5 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 17 Nov 2016 13:13:57 -0500
Received: from mx2.suse.de ([195.135.220.15]:48406 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S941817AbcKQSNy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Nov 2016 13:13:54 -0500
Date: Thu, 17 Nov 2016 10:13:45 -0800
From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wake_q: rename WAKE_Q to DEFINE_WAKE_Q
Message-ID: <20161117181345.GC18522@linux-80c1.suse>
References: <1479401198-1765-1-git-send-email-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1479401198-1765-1-git-send-email-longman@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 17 Nov 2016, Waiman Long wrote:

>Currently the wake_q data structure is defined by the WAKE_Q() macro.
>This macro, however, looks like a function doing something as "wake" is
>a verb. Even checkpatch.pl was confused as it reported warnings like
>
>  WARNING: Missing a blank line after declarations
>  #548: FILE: kernel/futex.c:3665:
>  +	int ret;
>  +	WAKE_Q(wake_q);
>
>This patch renames the WAKE_Q() macro to DEFINE_WAKE_Q() which clarifies
>what the macro is doing and eliminates the checkpatch.pl warnings.

No objection from me. Ack.