From: "Theodore Ts'o" <tytso@mit.edu>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Eric Biggers <ebiggers@google.com>,
fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] xfstests-bld: add f2fs support
Date: Thu, 17 Nov 2016 23:51:57 -0500 [thread overview]
Message-ID: <20161118045157.nclslkbhumszrggz@thunk.org> (raw)
In-Reply-To: <20161118043835.GA22707@jaegeuk>
On Thu, Nov 17, 2016 at 08:38:35PM -0800, Jaegeuk Kim wrote:
> > + /sbin/fsck.f2fs -f "$dev"
>
> Could you change to call fsck.f2fs instead of /sbin/xx?
> I'm almost finished to import f2fs-tools in xfstests-bld for kvm-xfstests.
> Given f2fs-tools from git, it seems /sbin/xx doesn't work.
So why won't /sbin/fsck.f2fs not work? The /sbin/fsck driver does
assume that /sbin/fsck.<type> will work, and other file systems do
have hard links or put their actual file system checker there:
% ls /sbin/fsck.*
36 /sbin/fsck.cramfs* 0 /sbin/fsck.ext3@ 60 /sbin/fsck.fat* 4 /sbin/fsck.nfs*
0 /sbin/fsck.exfat@ 0 /sbin/fsck.ext4@ 76 /sbin/fsck.minix* 0 /sbin/fsck.vfat@
0 /sbin/fsck.ext2@ 0 /sbin/fsck.ext4dev@ 0 /sbin/fsck.msdos@ 4 /sbin/fsck.xfs*
> > + /sbin/mkfs.f2fs -q $opts "$dev"
>
> Ditto, mkfs.f2fs.
Ditto:
% ls /sbin/mkfs.*
28 /sbin/mkfs.bfs* 0 /sbin/mkfs.ext3@ 76 /sbin/mkfs.minix* 352 /sbin/mkfs.xfs*
36 /sbin/mkfs.cramfs* 0 /sbin/mkfs.ext4@ 0 /sbin/mkfs.msdos@
0 /sbin/mkfs.exfat@ 0 /sbin/mkfs.ext4dev@ 0 /sbin/mkfs.ntfs@
0 /sbin/mkfs.ext2@ 36 /sbin/mkfs.fat* 0 /sbin/mkfs.vfat@
- Ted
next prev parent reply other threads:[~2016-11-18 4:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 19:52 [PATCH] xfstests-bld: add f2fs support Eric Biggers
2016-11-18 4:38 ` Jaegeuk Kim
2016-11-18 4:51 ` Theodore Ts'o [this message]
2016-11-18 5:11 ` Jaegeuk Kim
2016-11-18 16:22 ` Theodore Ts'o
2016-11-18 18:04 ` Jaegeuk Kim
2016-11-18 18:04 ` Jaegeuk Kim
2016-11-18 22:07 ` Theodore Ts'o
2016-12-08 3:22 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118045157.nclslkbhumszrggz@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.