All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Grace Kao <grace.kao@intel.com>
Subject: Re: [PATCH] CHROMIUM: ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88l25_max98357a machine
Date: Fri, 18 Nov 2016 15:55:06 +0530	[thread overview]
Message-ID: <20161118102506.GQ2698@localhost> (raw)
In-Reply-To: <20161118094810.GA1575@localhost.localdomain>

On Fri, Nov 18, 2016 at 09:48:10AM +0000, Charles Keepax wrote:
> > > +
> > > +	switch (cmd) {
> > > +	case SNDRV_PCM_TRIGGER_START:
> > > +		ret = snd_soc_dai_set_sysclk(codec_dai,	NAU8825_CLK_FLL_FS, 0,
> > > +			SND_SOC_CLOCK_IN);
> > > +		if (ret < 0)
> > > +			dev_err(codec_dai->dev, "can't set FS clock %d\n", ret);
> > > +		ret = snd_soc_dai_set_pll(codec_dai, 0, 0, runtime->rate,
> > > +			runtime->rate * 256);
> > > +		if (ret < 0)
> > > +			dev_err(codec_dai->dev, "can't set FLL: %d\n", ret);
> > > +		break;
> > 
> > starting clock on trigger doesnt sound right to me..
> > 
> 
> Me neither can't trigger be called from an atomic context? In
> which case I would expect operations on an external CODEC to be
> very likely to cause issues.

Not in this case :) We use non atomic triggers.. But that doesnt make this
correct :)

-- 
~Vinod

  reply	other threads:[~2016-11-18 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  6:35 [PATCH] CHROMIUM: ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88l25_max98357a machine Grace Kao
2016-11-18  5:28 ` Vinod Koul
2016-11-18  9:48   ` Charles Keepax
2016-11-18 10:25     ` Vinod Koul [this message]
2016-11-18  5:16 Grace Kao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118102506.GQ2698@localhost \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=grace.kao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.