From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7gQz-0000A7-Qn for qemu-devel@nongnu.org; Fri, 18 Nov 2016 05:30:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7gQy-00025C-Ve for qemu-devel@nongnu.org; Fri, 18 Nov 2016 05:30:17 -0500 Date: Fri, 18 Nov 2016 11:30:03 +0100 From: Olaf Hering Message-ID: <20161118103003.GD5717@aepfle.de> References: <20161118102452.5779-1-olaf@aepfle.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5" Content-Disposition: inline In-Reply-To: <20161118102452.5779-1-olaf@aepfle.de> Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Kevin Wolf , Max Reitz , "open list:X86" , "open list:All patches CC here" --+KJYzRxRHjYqLGl5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Fri, Nov 18, Olaf Hering wrote: > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) { > + goto err; How is error handling supposed to work here? Initially I forgot the "!", which just hung the mkfs command in domU. I have not yet tried to force errors in other part of that function. Olaf --+KJYzRxRHjYqLGl5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlgu2CgACgkQXUKg+qaYNn7wJwCfVEHyCEmZznhs5w134vCMBhh+ OikAoMyclH89HB66XZ/1fwJ0w4uNG0gH =/3u7 -----END PGP SIGNATURE----- --+KJYzRxRHjYqLGl5-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] xen_disk: convert discard input to byte ranges Date: Fri, 18 Nov 2016 11:30:03 +0100 Message-ID: <20161118103003.GD5717@aepfle.de> References: <20161118102452.5779-1-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5" Return-path: Content-Disposition: inline In-Reply-To: <20161118102452.5779-1-olaf@aepfle.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-block-bounces+gceqb-qemu-block=m.gmane.org@nongnu.org Sender: "Qemu-block" To: qemu-block@nongnu.org Cc: Kevin Wolf , Stefano Stabellini , "open list:All patches CC here" , Max Reitz , "open list:X86" , Anthony Perard List-Id: xen-devel@lists.xenproject.org --+KJYzRxRHjYqLGl5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Fri, Nov 18, Olaf Hering wrote: > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) { > + goto err; How is error handling supposed to work here? Initially I forgot the "!", which just hung the mkfs command in domU. I have not yet tried to force errors in other part of that function. Olaf --+KJYzRxRHjYqLGl5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlgu2CgACgkQXUKg+qaYNn7wJwCfVEHyCEmZznhs5w134vCMBhh+ OikAoMyclH89HB66XZ/1fwJ0w4uNG0gH =/3u7 -----END PGP SIGNATURE----- --+KJYzRxRHjYqLGl5--