Re: [RFC v3 1/6] Track the active utilisation

From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: luca abeni <luca.abeni@unitn.it>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Claudio Scordino <claudio@evidence.eu.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC v3 1/6] Track the active utilisation
Date: Fri, 18 Nov 2016 15:55:03 +0100	[thread overview]
Message-ID: <20161118145503.GL3142@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20161108175635.GF16920@e106622-lin>

On Tue, Nov 08, 2016 at 05:56:35PM +0000, Juri Lelli wrote:
> Mmm. You explicitly check that TASK_ON_RQ_MIGRATING or DEQUEUE_SLEEP
> (which btw can be actually put together with an or condition), so I
> don't think that any of those turn out to be true when the task dies.
> Also, AFAIU, do_exit() works on current and the TASK_DEAD case is
> handled in finish_task_switch(), so I don't think we are taking care of
> the "task is dying" condition.
> 
> Peter, does what I'm saying make any sense? :)

do_task_dead():
	__set_current_state(TASK_DEAD);
	schedule():
		if (prev->state)
			deactivate_task(DEQUEUE_SLEEP);