From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753656AbcKRSyZ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 Nov 2016 13:54:25 -0500
Received: from merlin.infradead.org ([205.233.59.134]:46660 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752528AbcKRSyY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Nov 2016 13:54:24 -0500
Date: Fri, 18 Nov 2016 19:54:25 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible
Message-ID: <20161118185425.GX3117@twins.programming.kicks-ass.net>
References: <180196e3754572540b595bc56b947d43658979a7.1479491159.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <180196e3754572540b595bc56b947d43658979a7.1479491159.git.jpoimboe@redhat.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2016 at 11:46:23AM -0600, Josh Poimboeuf wrote:
> NMI stack dumps are bracked by the following tags:
> 
>   <NMI>
>   ...
>   <EOE>
> 
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception).  The same ending tag is also used to mark the
> end of all other exceptions' stacks.  For example:
> 
>   <#DF>
>   ...
>   <EOE>
> 
> And similarly, "EOI" is used as the ending tag for interrupts:
> 
>   <IRQ>
>   ...
>   <EOI>
> 
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
> 
>   <NMI>
>   ...
>   </NMI>
> 
>   <#DF>
>   ...
>   </#DF>
> 
>   <IRQ>
>   ...
>   </IRQ>
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

>  arch/x86/include/asm/stacktrace.h |  3 +--
>  arch/x86/kernel/dumpstack.c       | 12 ++++++------
>  arch/x86/kernel/dumpstack_32.c    | 19 ++++++++-----------
>  arch/x86/kernel/dumpstack_64.c    | 22 ++++++++--------------
>  4 files changed, 23 insertions(+), 33 deletions(-)

And saves lines too, awesome!

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>