From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: i915_pages_create_for_stolen should return err ptr
Date: Fri, 18 Nov 2016 20:54:56 +0000 [thread overview]
Message-ID: <20161118205456.GB8045@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161118170855.GK28142@nuc-i3427.alporthouse.com>
On Fri, Nov 18, 2016 at 05:08:55PM +0000, Chris Wilson wrote:
> On Fri, Nov 18, 2016 at 05:02:16PM +0000, Matthew Auld wrote:
> > When gathering the pages from our backing storage we expect get_pages()
> > to either give us our sg_table or an err ptr. However when gathering our
> > fake pages for stolen memory we may return NULL in the event of a
> > failure. To prevent any funny business we should therefore return the
> > proper err ptr value.
> >
> > Fixes: 03ac84f1830e ("drm/i915: Pass around sg_table to get_pages/put_pages backend")
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
And pushed, thanks for the patch.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-18 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 17:02 [PATCH] drm/i915: i915_pages_create_for_stolen should return err ptr Matthew Auld
2016-11-18 17:08 ` Chris Wilson
2016-11-18 20:54 ` Chris Wilson [this message]
2016-11-18 17:46 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118205456.GB8045@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.