All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Biggers <ebiggers@google.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	kernel@kyup.com, bp@alien8.de, stable@vger.kernel.org
Subject: Re: [PATCH 3/4] ext4: use more strict checks for inodes_per_block on mount
Date: Fri, 18 Nov 2016 16:56:30 -0500	[thread overview]
Message-ID: <20161118215630.ubdxrgo2rmtapoap@thunk.org> (raw)
In-Reply-To: <20161118203046.GB100623@google.com>

On Fri, Nov 18, 2016 at 12:30:46PM -0800, Eric Biggers wrote:
> On Fri, Nov 18, 2016 at 01:38:41PM -0500, Theodore Ts'o wrote:
> > Centralize the checks for inodes_per_block and be more strict to make
> > sure the inodes_per_block_group can't end up being zero.
> 
> Nit: this should say 's_inodes_per_group', not 'inodes_per_block_group'.
> > 
> > +	    sbi->s_inodes_per_group > blocksize * 8) {
> > +		ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n",
> > +			 sbi->s_blocks_per_group);
> > +		goto failed_mount;
> > +	}
> 
> Should print out s_inodes_per_group, not s_blocks_per_group.

Thanks, good catch.  I'll fix both of these.

					- Ted

  reply	other threads:[~2016-11-18 21:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 18:38 [PATCH 1/4] ext4: sanity check the block and cluster size at mount time Theodore Ts'o
2016-11-18 18:38 ` [PATCH 2/4] ext4: fix in-superblock mount options processing Theodore Ts'o
2016-11-18 20:27   ` Eric Biggers
2016-11-18 18:38 ` [PATCH 3/4] ext4: use more strict checks for inodes_per_block on mount Theodore Ts'o
2016-11-18 20:30   ` Eric Biggers
2016-11-18 21:56     ` Theodore Ts'o [this message]
2016-11-18 18:38 ` [PATCH 4/4] ext4: add sanity checking to count_overhead() Theodore Ts'o
2016-11-18 20:02 ` [PATCH 1/4] ext4: sanity check the block and cluster size at mount time Eric Biggers
2016-11-18 21:55   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118215630.ubdxrgo2rmtapoap@thunk.org \
    --to=tytso@mit.edu \
    --cc=bp@alien8.de \
    --cc=ebiggers@google.com \
    --cc=kernel@kyup.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.