From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbcKSIs5 (ORCPT ); Sat, 19 Nov 2016 03:48:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57054 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbcKSIsz (ORCPT ); Sat, 19 Nov 2016 03:48:55 -0500 Date: Sat, 19 Nov 2016 09:49:04 +0100 From: Greg Kroah-Hartman To: "Winkler, Tomas" Cc: "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" Subject: Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX Message-ID: <20161119084904.GA22816@kroah.com> References: <1479329490-23176-1-git-send-email-tomas.winkler@intel.com> <1479329490-23176-5-git-send-email-tomas.winkler@intel.com> <20161117153719.GA2958@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B5432B3EB@hasmsx108.ger.corp.intel.com> <20161117162744.GA20671@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B5432C477@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B5432C477@hasmsx108.ger.corp.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2016 at 07:30:25PM +0000, Winkler, Tomas wrote: > > > > > On Thu, Nov 17, 2016 at 04:22:24PM +0000, Winkler, Tomas wrote: > > > > Just make a new function mei_cldev_recv_async() and then call a > > > > local, static function, that does the work with the correct flag > > > > set. That way the developer always knows exactly what is going on. > > > > > > We can do a wrapper, but _async() is not proper here maybe > > > _nonblock(), > > > > Yes, I just guessed at the name :) > > Understood, any how I believe that we should keep patch as is, there is no one > API _nonblock() function in the whole kernel unlike _async(), > nonblock is always passed in as a flag or Boolean. And I'll still argue that this is a horrible api and you can do better. No need to duplicate the errors of our childhood :) thanks, greg k-h