All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: daniel@iogearbox.net, eric.dumazet@gmail.com, mst@redhat.com,
	kubakici@wp.pl, shm@cumulusnetworks.com, davem@davemloft.net,
	alexei.starovoitov@gmail.com
Cc: netdev@vger.kernel.org, bblanco@plumgrid.com,
	john.fastabend@gmail.com, john.r.fastabend@intel.com,
	brouer@redhat.com, tgraf@suug.ch
Subject: [net-next PATCH v2 2/5] net: xdp: add invalid buffer warning
Date: Sat, 19 Nov 2016 18:50:04 -0800	[thread overview]
Message-ID: <20161120025004.19187.84665.stgit@john-Precision-Tower-5810> (raw)
In-Reply-To: <20161120024710.19187.31037.stgit@john-Precision-Tower-5810>

This adds a warning for drivers to use when encountering an invalid
buffer for XDP. For normal cases this should not happen but to catch
this in virtual/qemu setups that I may not have expected from the
emulation layer having a standard warning is useful.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
 include/linux/filter.h |    1 +
 net/core/filter.c      |    6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/include/linux/filter.h b/include/linux/filter.h
index 1f09c52..0c79004 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -595,6 +595,7 @@ int sk_get_filter(struct sock *sk, struct sock_filter __user *filter,
 struct bpf_prog *bpf_patch_insn_single(struct bpf_prog *prog, u32 off,
 				       const struct bpf_insn *patch, u32 len);
 void bpf_warn_invalid_xdp_action(u32 act);
+void bpf_warn_invalid_xdp_buffer(void);
 
 #ifdef CONFIG_BPF_JIT
 extern int bpf_jit_enable;
diff --git a/net/core/filter.c b/net/core/filter.c
index dece94f..b777730 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2774,6 +2774,12 @@ void bpf_warn_invalid_xdp_action(u32 act)
 }
 EXPORT_SYMBOL_GPL(bpf_warn_invalid_xdp_action);
 
+void bpf_warn_invalid_xdp_buffer(void)
+{
+	WARN_ONCE(1, "Illegal XDP buffer encountered, expect packet loss\n");
+}
+EXPORT_SYMBOL_GPL(bpf_warn_invalid_xdp_buffer);
+
 static u32 sk_filter_convert_ctx_access(enum bpf_access_type type, int dst_reg,
 					int src_reg, int ctx_off,
 					struct bpf_insn *insn_buf,

  parent reply	other threads:[~2016-11-20  2:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20  2:49 [net-next PATCH v2 0/5] XDP for virtio_net John Fastabend
2016-11-20  2:49 ` [net-next PATCH v2 1/5] net: virtio dynamically disable/enable LRO John Fastabend
2016-11-21 23:23   ` Michael S. Tsirkin
2016-11-22  8:16     ` John Fastabend
2016-11-20  2:50 ` John Fastabend [this message]
2016-11-20  2:50 ` [net-next PATCH v2 3/5] virtio_net: Add XDP support John Fastabend
2016-11-21 23:20   ` Michael S. Tsirkin
2016-11-22  8:27     ` John Fastabend
2016-11-22 14:58       ` Michael S. Tsirkin
2016-11-25 21:24         ` John Fastabend
2016-11-28  3:36           ` Michael S. Tsirkin
2016-11-28  3:56             ` John Fastabend
2016-11-28  4:07               ` Michael S. Tsirkin
2016-11-28 23:26                 ` John Fastabend
2016-11-20  2:51 ` [net-next PATCH v2 4/5] virtio_net: add dedicated XDP transmit queues John Fastabend
2016-11-21 11:45   ` Daniel Borkmann
2016-11-21 15:56     ` John Fastabend
2016-11-21 23:13   ` Michael S. Tsirkin
2016-11-22  8:17     ` John Fastabend
2016-11-22 14:59       ` Michael S. Tsirkin
2016-11-20  2:51 ` [net-next PATCH v2 5/5] virtio_net: add XDP_TX support John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161120025004.19187.84665.stgit@john-Precision-Tower-5810 \
    --to=john.fastabend@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bblanco@plumgrid.com \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=john.r.fastabend@intel.com \
    --cc=kubakici@wp.pl \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shm@cumulusnetworks.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.