All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Andi Kleen <andi@firstfloor.org>,
	Jan Stancek <jstancek@redhat.com>
Subject: Re: [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage!
Date: Mon, 21 Nov 2016 13:49:16 +0100	[thread overview]
Message-ID: <20161121124916.GA12577@krava> (raw)
In-Reply-To: <20161121113131.GA3092@twins.programming.kicks-ass.net>

On Mon, Nov 21, 2016 at 12:31:31PM +0100, Peter Zijlstra wrote:
> On Mon, Nov 21, 2016 at 12:22:29PM +0100, Jiri Olsa wrote:
> > On Mon, Nov 21, 2016 at 10:42:27AM +0100, Peter Zijlstra wrote:
> > > On Mon, Nov 21, 2016 at 10:34:25AM +0100, Jiri Olsa wrote:
> > > > On Mon, Nov 21, 2016 at 10:28:50AM +0100, Peter Zijlstra wrote:
> > > 
> > > > > I think I prefer something like the below, that only annotates the one
> > > > > RDMSR in question, instead of all of them.
> > > > 
> > > > I was wondering about that, but haven't found RCU_NONIDLE 
> > > 
> > > Its in rcupdate.h ;-)
> > 
> > it was too late in the morning.. ;-) I'm assuming you'll queue this patch.. ?
> 
> Probably, I still have to make pretty the uncore patch from last week,
> and I have a PEBS patch that needs looking at :-)
> 
> BTW, if you have any opinion on that PEBS register set crap, do holler
> :-)
> 
>   lkml.kernel.org/r/20161117171731.GV3157@twins.programming.kicks-ass.net

ook, will check

thanks,
jirka

  reply	other threads:[~2016-11-21 12:49 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21  0:53 [BUG] msr-trace.h:42 suspicious rcu_dereference_check() usage! Jiri Olsa
2016-11-21  9:02 ` Paul E. McKenney
2016-11-21  9:43   ` Peter Zijlstra
2016-11-21 11:00     ` Paul E. McKenney
2016-11-21  9:28 ` Peter Zijlstra
2016-11-21  9:34   ` Jiri Olsa
2016-11-21  9:42     ` Peter Zijlstra
2016-11-21 11:22       ` Jiri Olsa
2016-11-21 11:31         ` Peter Zijlstra
2016-11-21 12:49           ` Jiri Olsa [this message]
2016-11-21 12:58     ` Peter Zijlstra
2016-11-21 14:15       ` Steven Rostedt
2016-11-21 14:37         ` Peter Zijlstra
2016-11-21 15:35           ` Borislav Petkov
2016-11-21 15:41             ` Peter Zijlstra
2016-11-21 16:06               ` Borislav Petkov
2016-11-29 13:16                 ` Borislav Petkov
2016-11-29 13:59                   ` Thomas Gleixner
2016-11-30  8:48                     ` Borislav Petkov
2016-11-30  8:54                       ` Thomas Gleixner
2016-11-30  9:07                         ` Borislav Petkov
2016-11-30  9:14                           ` Thomas Gleixner
2016-11-29 14:04                   ` Jiri Olsa
2016-11-21 14:20       ` Steven Rostedt
2016-11-21 17:06   ` Andi Kleen
2016-11-21 17:18     ` Peter Zijlstra
2016-11-21 17:45       ` Andi Kleen
2016-11-21 18:01         ` Steven Rostedt
2016-11-21 18:06           ` Andi Kleen
2016-11-21 18:22             ` Steven Rostedt
2016-11-21 18:37               ` Andi Kleen
2016-11-21 19:06                 ` Steven Rostedt
2016-11-21 19:15                 ` Steven Rostedt
2016-11-21 20:44                   ` Andi Kleen
2016-11-22  8:19                     ` Paul E. McKenney
2016-11-22 14:39                 ` Steven Rostedt
2016-11-22 19:05                   ` Andi Kleen
2016-11-24  2:06                 ` Steven Rostedt
2016-11-28 21:48                   ` Andi Kleen
2016-11-28 22:46                     ` Steven Rostedt
2016-11-28 23:10                       ` Andi Kleen
2016-11-21 17:55       ` Steven Rostedt
2016-11-21 18:24         ` Steven Rostedt
2016-11-21 20:12           ` Paul E. McKenney
2017-02-23 12:24   ` Jiri Olsa
2017-02-23 17:11     ` Andi Kleen
2017-02-23 17:28     ` Peter Zijlstra
2017-02-23 17:56       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121124916.GA12577@krava \
    --to=jolsa@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=josh@joshtriplett.org \
    --cc=jstancek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.