All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>, Greg KH <gregkh@linuxfoundation.org>
Cc: Badhri Jagan Sridharan <badhri@google.com>,
	Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv11 2/3] usb: USB Type-C connector class
Date: Mon, 21 Nov 2016 16:23:06 +0200	[thread overview]
Message-ID: <20161121142306.GC18501@kuha.fi.intel.com> (raw)
In-Reply-To: <20161121131103.GA18501@kuha.fi.intel.com>

On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote:
> Hi Greg,
> 
> On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote:
> > > +static void typec_partner_release(struct device *dev)
> > > +{
> > > +	struct typec_port *port = to_typec_port(dev->parent);
> > > +
> > > +	typec_unregister_altmodes(dev);
> > > +	port->partner = NULL;
> > > +}
> > 
> > This doesn't feel right, why are you both exporting
> > typec_unregister_altmodes() and also calling it from release callbacks?
> > That implies there is two way to clean stuff up, so what is a driver
> > writer to use?  Please simplify and force it to be one way or the other.
> 
> OK.

Guenter did you need to also remove the alternate modes in drivers, or
can we just do it here?

Thanks,

-- 
heikki

  reply	other threads:[~2016-11-21 14:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 10:50 [PATCHv11 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-21 10:33   ` Greg KH
2016-11-21 13:27     ` Heikki Krogerus
2016-11-21 14:46       ` Greg KH
2016-11-22  7:58         ` Heikki Krogerus
2016-11-22  8:19           ` Greg KH
2016-11-21 10:35   ` Greg KH
2016-11-21 13:11     ` Heikki Krogerus
2016-11-21 14:23       ` Heikki Krogerus [this message]
2016-11-21 15:33         ` Guenter Roeck
2016-11-22  8:52           ` Heikki Krogerus
2016-11-21 14:45       ` Greg KH
2016-11-22 10:51         ` Heikki Krogerus
2016-11-22 13:37           ` Heikki Krogerus
2016-11-22 13:45         ` Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121142306.GC18501@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=badhri@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.