From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Mon, 21 Nov 2016 14:30:53 +0000 Subject: [BUG] hdlcd gets confused about base address In-Reply-To: <20161121132419.GF1041@n2100.armlinux.org.uk> References: <20161118233733.GP1041@n2100.armlinux.org.uk> <20161121110604.GC1005@e106497-lin.cambridge.arm.com> <20161121112030.GC1041@n2100.armlinux.org.uk> <20161121113212.GF1005@e106497-lin.cambridge.arm.com> <20161121122556.GE1041@n2100.armlinux.org.uk> <20161121125653.GJ1005@e106497-lin.cambridge.arm.com> <20161121132419.GF1041@n2100.armlinux.org.uk> Message-ID: <20161121143053.GH1041@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 21, 2016 at 01:24:19PM +0000, Russell King - ARM Linux wrote: > On Mon, Nov 21, 2016 at 12:56:53PM +0000, Liviu Dudau wrote: > > That is mostly due to the check in hdlcd_crtc_disable() which I should > > remove, I've added it because I was getting a ->disable() hook call > > before any ->enable() was called at startup time. I need to revisit > > this as I remember Daniel was commenting that this was not needed. > > Removing that test results in: > > [drm:drm_atomic_helper_commit_cleanup_done] *ERROR* [CRTC:24:crtc-0] flip_done timed out > > and the kernel hanging, seemingly in an IRQs-off region. Annoyingly, enabling DRM debug prevents the kernel hanging... -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [BUG] hdlcd gets confused about base address Date: Mon, 21 Nov 2016 14:30:53 +0000 Message-ID: <20161121143053.GH1041@n2100.armlinux.org.uk> References: <20161118233733.GP1041@n2100.armlinux.org.uk> <20161121110604.GC1005@e106497-lin.cambridge.arm.com> <20161121112030.GC1041@n2100.armlinux.org.uk> <20161121113212.GF1005@e106497-lin.cambridge.arm.com> <20161121122556.GE1041@n2100.armlinux.org.uk> <20161121125653.GJ1005@e106497-lin.cambridge.arm.com> <20161121132419.GF1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161121132419.GF1041@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Liviu Dudau Cc: David Airlie , Mali DP Maintainers , Brian Starkey , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org On Mon, Nov 21, 2016 at 01:24:19PM +0000, Russell King - ARM Linux wrote: > On Mon, Nov 21, 2016 at 12:56:53PM +0000, Liviu Dudau wrote: > > That is mostly due to the check in hdlcd_crtc_disable() which I should > > remove, I've added it because I was getting a ->disable() hook call > > before any ->enable() was called at startup time. I need to revisit > > this as I remember Daniel was commenting that this was not needed. > > Removing that test results in: > > [drm:drm_atomic_helper_commit_cleanup_done] *ERROR* [CRTC:24:crtc-0] flip_done timed out > > and the kernel hanging, seemingly in an IRQs-off region. Annoyingly, enabling DRM debug prevents the kernel hanging... -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.